From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 587CBC001B0 for ; Mon, 14 Aug 2023 14:09:43 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5DC471F1; Mon, 14 Aug 2023 16:08:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5DC471F1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1692022181; bh=q1bF0M0Z60l5z0SrmLHcCPMfxrtvXjd7D+J79KEYuOE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=dyxVm8HRvSbnf5oJ4EQlQ3belJQxsm7YwjKs1028BydqxvCBQw1JeP9GKmho3GHAF xL5p5vPnNtbWJJKLd9Pd5/JU1AadgMnguWFpfq5KvbdWkaqgSs/jI3CJVcvyNDYC99 XtPKNu0fr3n9lJsE/S/dS2nWtH0POS7Tppq2UnqI= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 08D93F80510; Mon, 14 Aug 2023 16:08:28 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 9627CF801EB; Mon, 14 Aug 2023 16:08:27 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0E247F80510; Mon, 14 Aug 2023 16:08:23 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A97F6F80254; Mon, 14 Aug 2023 16:07:28 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A97F6F80254 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=ZwWpOzWk DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692022052; x=1723558052; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=q1bF0M0Z60l5z0SrmLHcCPMfxrtvXjd7D+J79KEYuOE=; b=ZwWpOzWkLRMMLmTJL2DG3eZQEncJQPcZl0dTwuNgJBYj/Ieq+DoRMq8q PWNhgFGwDK7UV3SzviRUlWgIO/H/01x28LxsIPvu7Uht+7ttWphiNiGes OtEjyXwmvZewLtm2+ZMiOFK2ydJrOd0DsKjZOmeTpt62jv8fn7KKsMLVc Jgt/3Nd9bBMcV05W3irhTXBjmdpnrFIR+ZBK+6bFjtxzmj2MHbwlGtoD0 gZhI+gsX0ERaNQXJ6k/YPMMkKKUQkGIAs5liRN0XO+ZmOAIoMOM2IPCDh FK/tBV2eoRPy3q4mYJhD0vORsYpbyy6n9Gj2aVJ5j0sKq00SStB05KmYc w==; X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="370943687" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="370943687" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 07:07:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10802"; a="798825224" X-IronPort-AV: E=Sophos;i="6.01,172,1684825200"; d="scan'208";a="798825224" Received: from ryana2x-mobl.amr.corp.intel.com (HELO [10.212.126.76]) ([10.212.126.76]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Aug 2023 07:07:25 -0700 Message-ID: <4f5d8095-537b-433e-4839-6061beb2b0bb@linux.intel.com> Date: Mon, 14 Aug 2023 08:55:36 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [PATCH] ASoC: SOF: Intel: fix hda_sdw_check_wakeen_irq() Content-Language: en-US To: Arnd Bergmann , Mark Brown Cc: Arnd Bergmann , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Jaroslav Kysela , Takashi Iwai , Rander Wang , sound-open-firmware@alsa-project.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Nathan Chancellor References: <20230814074711.1068093-1-arnd@kernel.org> From: Pierre-Louis Bossart In-Reply-To: <20230814074711.1068093-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: OVLIFU4CYNCX5IBSFA4MC2XHPDEFZXXK X-Message-ID-Hash: OVLIFU4CYNCX5IBSFA4MC2XHPDEFZXXK X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/14/23 02:46, Arnd Bergmann wrote: > From: Arnd Bergmann > > This function cannot work, as the 'chip' variable is never initialized: > > sound/soc/sof/intel/hda.c:423:6: error: variable 'chip' is uninitialized when used here [-Werror,-Wuninitialized] > if (chip && chip->check_sdw_wakeen_irq) > ^~~~ > > Set it the same way that other functions in this file do. > > Fixes: 9362ab78f175d ("ASoC: SOF: Intel: add abstraction for SoundWire wake-ups") > Signed-off-by: Arnd Bergmann > --- > There hasn't been a new linux-next in a few days, so there is a good chance > someone else already fixed this in the meantime. Sending out my fix in case > that hasn't happened yet. yes it was found by Nathan Chancelor and corrected already. Thanks for checking though! > --- > sound/soc/sof/intel/hda.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/sof/intel/hda.c b/sound/soc/sof/intel/hda.c > index 04c748a72b137..6c9c7b390cf53 100644 > --- a/sound/soc/sof/intel/hda.c > +++ b/sound/soc/sof/intel/hda.c > @@ -415,7 +415,7 @@ bool hda_sdw_check_wakeen_irq_common(struct snd_sof_dev *sdev) > static bool hda_sdw_check_wakeen_irq(struct snd_sof_dev *sdev) > { > u32 interface_mask = hda_get_interface_mask(sdev); > - const struct sof_intel_dsp_desc *chip; > + const struct sof_intel_dsp_desc *chip = get_chip_info(sdev->pdata); > > if (!(interface_mask & BIT(SOF_DAI_INTEL_ALH))) > return false;