From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Shreyas NC <shreyas.nc@intel.com>, alsa-devel@alsa-project.org
Cc: patches.audio@intel.com, gregkh@linuxfoundation.org,
vkoul@kernel.org, sanyog.r.kale@intel.com
Subject: Re: [PATCH v5 0/9] soundwire: Add multi link support
Date: Mon, 9 Jul 2018 18:47:21 -0500 [thread overview]
Message-ID: <4fa8a49a-f7d5-6d04-1df1-b47af2d7db4d@linux.intel.com> (raw)
In-Reply-To: <1530791196-15483-1-git-send-email-shreyas.nc@intel.com>
On 07/05/2018 06:46 AM, Shreyas NC wrote:
> Currently, in the SoundWire subsystem, the concept of stream is
> limited to a Master and one or more Slaves(Codecs). This series
> aims to add support for multiple Master(s) sharing the same
> reference clock and synchronized in the hardware.
>
> This patch series adds:
> - Fix to avoid duplicate stream state assignment
> - Avoid incorrect stream release after configuring Master
> - Helpers to lock bus instances part of the stream
> - Boiler plate conversion of code to support a list of
> Master runtime
> - Support multi link bank switch to support synchronization
> between multiple masters
> - Add Intel platform ops for pre/post bank switch
>
> changes in v5:
> - Add patch to fix duplicate stream state assignment
> - fix incorrect exit which was releasing the stream after
> configuring master
> - In sdw_release_bus_lock(), release the mutex in reverse order
> as suggested by Takashi
It's almost good, I just had a couple of comments on the error cases and
the lock handling on release.
Can we respin a quick v6?
>
> changes in v4:
> - Added changes in sdw_stream_runtime structure to track Masters
> added to stream
> - Add changes to support ml_bankswitch only if both the hardware
> supports and the stream is handled by multiple masters
>
> Sanyog Kale (2):
> Documentation: soundwire: Add documentation for multi link
> soundwire: Add support to lock across bus instances
>
> Shreyas NC (6):
> soundwire: Fix duplicate stream state assignment
> soundwire: fix incorrect exit after configuring stream
> soundwire: Initialize completion for defer messages
> soundwire: keep track of Masters in a stream
> soundwire: Add support for multi link bank switch
> soundwire: intel: Add pre/post bank switch ops
>
> Vinod Koul (1):
> soundwire: Handle multiple master instances in a stream
>
> Documentation/driver-api/soundwire/stream.rst | 28 ++
> drivers/soundwire/bus.c | 6 +
> drivers/soundwire/bus.h | 4 +
> drivers/soundwire/intel.c | 65 ++++
> drivers/soundwire/stream.c | 502 +++++++++++++++++++-------
> include/linux/soundwire/sdw.h | 12 +-
> 6 files changed, 483 insertions(+), 134 deletions(-)
>
prev parent reply other threads:[~2018-07-09 23:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 11:46 [PATCH v5 0/9] soundwire: Add multi link support Shreyas NC
2018-07-05 11:46 ` [PATCH v5 1/9] soundwire: Fix duplicate stream state assignment Shreyas NC
2018-07-09 23:41 ` Pierre-Louis Bossart
2018-07-10 17:03 ` Sanyog Kale
2018-07-05 11:46 ` [PATCH v5 2/9] soundwire: fix incorrect exit after configuring stream Shreyas NC
2018-07-05 11:46 ` [PATCH v5 3/9] Documentation: soundwire: Add documentation for multi link Shreyas NC
2018-07-05 11:46 ` [PATCH v5 4/9] soundwire: Initialize completion for defer messages Shreyas NC
2018-07-05 11:46 ` [PATCH v5 5/9] soundwire: Add support to lock across bus instances Shreyas NC
2018-07-05 11:46 ` [PATCH v5 6/9] soundwire: Handle multiple master instances in a stream Shreyas NC
2018-07-09 23:42 ` Pierre-Louis Bossart
2018-07-10 17:02 ` Sanyog Kale
2018-07-10 18:16 ` Pierre-Louis Bossart
2018-07-11 3:47 ` Sanyog Kale
2018-07-05 11:46 ` [PATCH v5 7/9] soundwire: keep track of Masters " Shreyas NC
2018-07-05 11:46 ` [PATCH v5 8/9] soundwire: Add support for multi link bank switch Shreyas NC
2018-07-09 23:22 ` Pierre-Louis Bossart
2018-07-10 16:37 ` Sanyog Kale
2018-07-05 11:46 ` [PATCH v5 9/9] soundwire: intel: Add pre/post bank switch ops Shreyas NC
2018-07-09 23:47 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fa8a49a-f7d5-6d04-1df1-b47af2d7db4d@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=gregkh@linuxfoundation.org \
--cc=patches.audio@intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=shreyas.nc@intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).