From: "Gabriel M. Beddingfield" <gabrbedd@gmail.com>
To: Rajeev kumar <rajeev-dlh.kumar@st.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 1/2] MFD: twl6040: Fix revision information
Date: Tue, 17 Jul 2012 06:55:12 -0500 [thread overview]
Message-ID: <500552A0.7020301@gmail.com> (raw)
In-Reply-To: <500508B0.9010009@st.com>
On 07/17/2012 01:39 AM, Rajeev kumar wrote:
>> diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
>> index a36e9fc..2786de2 100644
>> --- a/sound/soc/codecs/twl6040.c
>> +++ b/sound/soc/codecs/twl6040.c
>> @@ -653,7 +653,7 @@ int twl6040_get_hs_step_size(struct snd_soc_codec
>> *codec)
>> {
>> struct twl6040 *twl6040 = codec->control_data;
>>
>> - if (twl6040_get_revid(twl6040)< TWL6040_REV_ES1_2)
>> + if (twl6040_get_revid(twl6040)< TWL6040_REV_ES1_3)
>
>
> Instead of doing this change why not you take a #define for revision and
> do
> if (twl6040_get_revid(twl6040)< TWL6040_REV)
I disagree. The driver isn't just for one revision... it's for all of
them. Peter's code is pretty clear as to what the situation is. Your
suggestion hides it.
-gabriel
next prev parent reply other threads:[~2012-07-17 11:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 9:49 [PATCH 0/2] MFD: twl6040: Version support fixes, additions Peter Ujfalusi
2012-07-16 9:49 ` [PATCH 1/2] MFD: twl6040: Fix revision information Peter Ujfalusi
2012-07-17 6:39 ` Rajeev kumar
2012-07-17 11:55 ` Gabriel M. Beddingfield [this message]
2012-07-17 13:01 ` Peter Ujfalusi
2012-07-16 9:49 ` [PATCH 2/2] MFD: twl6040: Add support for twl6041 Peter Ujfalusi
2012-07-24 22:27 ` [PATCH 0/2] MFD: twl6040: Version support fixes, additions Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500552A0.7020301@gmail.com \
--to=gabrbedd@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).