From: Daniel Mack <zonque@gmail.com>
To: Timur Tabi <timur@freescale.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
lrg@ti.com
Subject: Re: [PATCH 1/2] ALSA: ASoC: add DT bindings for cs4270
Date: Wed, 25 Jul 2012 08:19:20 +0200 [thread overview]
Message-ID: <500F8FE8.3070501@gmail.com> (raw)
In-Reply-To: <500F0D2C.9010600@freescale.com>
On 24.07.2012 23:01, Timur Tabi wrote:
> Also, I have a gut feeling that if someone else needs to do the same
> thing, then this code:
>
> devm_gpio_request_one(&i2c_client->dev, reset_gpio,
> reset_gpio_flags & OF_GPIO_ACTIVE_LOW ?
> GPIOF_OUT_INIT_LOW : GPIOF_OUT_INIT_HIGH,
> "cs4270 reset")
>
> won't work for him, because it's not generic enough.
Why is that? The GPIO in the spec can be located anywhere on the board,
either directly driven by the SoC or by any arbitrary other part on on
the board that exposes itself as GPIO chip. And with the ACTIVE_LOW
flag, it's even possible to compensate external circuitry that changes
the polarity.
Which case can you imagine where that flexibility wouldn't suffice?
Daniel
next prev parent reply other threads:[~2012-07-25 6:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 20:20 [PATCH 1/2] ALSA: ASoC: add DT bindings for cs4270 Daniel Mack
2012-07-24 20:20 ` [PATCH 2/2] ALSA: ASoC: Add reset-gpio DT property to cs4270 driver Daniel Mack
2012-07-24 20:22 ` [PATCH 1/2] ALSA: ASoC: add DT bindings for cs4270 Timur Tabi
2012-07-24 20:26 ` Daniel Mack
2012-07-24 20:30 ` Timur Tabi
2012-07-24 20:32 ` Daniel Mack
2012-07-24 20:39 ` Timur Tabi
2012-07-24 20:53 ` Daniel Mack
2012-07-24 21:01 ` Timur Tabi
2012-07-25 6:19 ` Daniel Mack [this message]
2012-07-24 22:01 ` Stephen Warren
2012-07-24 22:02 ` Timur Tabi
2012-07-24 22:42 ` Mark Brown
2012-07-24 22:41 ` Mark Brown
2012-07-24 22:00 ` Stephen Warren
2012-07-24 22:03 ` Timur Tabi
2012-07-24 22:44 ` Mark Brown
2012-07-25 6:12 ` Daniel Mack
2012-07-25 7:03 ` [PATCH 2/2 v2] ALSA: ASoC: Add reset-gpio DT property to cs4270 driver Daniel Mack
2012-07-25 13:18 ` Mark Brown
2012-07-25 13:22 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500F8FE8.3070501@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).