From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Ola Lilja <ola.o.lilja@stericsson.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: ab8500: Remove pointless cast
Date: Thu, 26 Jul 2012 16:07:04 +0100 [thread overview]
Message-ID: <50115D18.3040703@linaro.org> (raw)
In-Reply-To: <1343314151-26442-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On 26/07/12 15:49, Mark Brown wrote:
> There's never any need to cast away from void.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/ab8500-codec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
> index 3c79592..05d70934 100644
> --- a/sound/soc/codecs/ab8500-codec.c
> +++ b/sound/soc/codecs/ab8500-codec.c
> @@ -2405,7 +2405,7 @@ static int ab8500_codec_probe(struct snd_soc_codec *codec)
> dev_dbg(dev, "%s: Enter.\n", __func__);
>
> /* Setup AB8500 according to board-settings */
> - pdata = (struct ab8500_platform_data *)dev_get_platdata(dev->parent);
> + pdata = dev_get_platdata(dev->parent);
> status = ab8500_audio_setup_mics(codec, &pdata->codec->amics);
> if (status < 0) {
> pr_err("%s: Failed to setup mics (%d)!\n", __func__, status);
>
I think Ola needs to ACK this, but fwiw:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
prev parent reply other threads:[~2012-07-26 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 14:49 [PATCH] ASoC: ab8500: Remove pointless cast Mark Brown
2012-07-26 15:07 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50115D18.3040703@linaro.org \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=ola.o.lilja@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).