[PATCH] ASoC: ab8500: Remove pointless cast

[PATCH] ASoC: ab8500: Remove pointless cast

[Mark Brown]

There's never any need to cast away from void.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 sound/soc/codecs/ab8500-codec.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
index 3c79592..05d70934 100644
--- a/sound/soc/codecs/ab8500-codec.c
+++ b/sound/soc/codecs/ab8500-codec.c
@@ -2405,7 +2405,7 @@ static int ab8500_codec_probe(struct snd_soc_codec *codec)
 	dev_dbg(dev, "%s: Enter.\n", __func__);
 
 	/* Setup AB8500 according to board-settings */
-	pdata = (struct ab8500_platform_data *)dev_get_platdata(dev->parent);
+	pdata = dev_get_platdata(dev->parent);
 	status = ab8500_audio_setup_mics(codec, &pdata->codec->amics);
 	if (status < 0) {
 		pr_err("%s: Failed to setup mics (%d)!\n", __func__, status);
-- 
1.7.10.4

Re: [PATCH] ASoC: ab8500: Remove pointless cast

[Lee Jones]

On 26/07/12 15:49, Mark Brown wrote:
> There's never any need to cast away from void.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>   sound/soc/codecs/ab8500-codec.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
> index 3c79592..05d70934 100644
> --- a/sound/soc/codecs/ab8500-codec.c
> +++ b/sound/soc/codecs/ab8500-codec.c
> @@ -2405,7 +2405,7 @@ static int ab8500_codec_probe(struct snd_soc_codec *codec)
>   	dev_dbg(dev, "%s: Enter.\n", __func__);
>
>   	/* Setup AB8500 according to board-settings */
> -	pdata = (struct ab8500_platform_data *)dev_get_platdata(dev->parent);
> +	pdata = dev_get_platdata(dev->parent);
>   	status = ab8500_audio_setup_mics(codec, &pdata->codec->amics);
>   	if (status < 0) {
>   		pr_err("%s: Failed to setup mics (%d)!\n", __func__, status);
>

I think Ola needs to ACK this, but fwiw:

Acked-by: Lee Jones <lee.jones@linaro.org>

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel