From: "Gaëtan Carlier" <gcembed@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
kernel@pengutronix.de
Subject: Re: [PATCH v2] ASoC: imx-ssi: Remove mono support
Date: Wed, 08 Aug 2012 15:18:38 +0200 [thread overview]
Message-ID: <5022672E.8080502@gmail.com> (raw)
In-Reply-To: <1344369094-24085-1-git-send-email-festevam@gmail.com>
Hi,
On 08/07/2012 09:51 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Playing a mono track results in incorrect playback rate, ie, the audio
> is played at a faster rate.
>
> Remove mono support in the driver by setting 'channes_min' to dual-channel
> and this allows mono tracks to be played correctly.
>
> Reported-by: Gaëtan Carlier <gcembed@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Also change 'channels_min' for the capture
> - Improve the commit log
> sound/soc/fsl/imx-ssi.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c
> index 3c520c4..7074ae6 100644
> --- a/sound/soc/fsl/imx-ssi.c
> +++ b/sound/soc/fsl/imx-ssi.c
> @@ -380,13 +380,14 @@ static int imx_ssi_dai_probe(struct snd_soc_dai *dai)
> static struct snd_soc_dai_driver imx_ssi_dai = {
> .probe = imx_ssi_dai_probe,
> .playback = {
> - .channels_min = 1,
> + /* The SSI does not support monaural audio. */
> + .channels_min = 2,
> .channels_max = 2,
> .rates = SNDRV_PCM_RATE_8000_96000,
> .formats = SNDRV_PCM_FMTBIT_S16_LE,
> },
> .capture = {
> - .channels_min = 1,
> + .channels_min = 2,
> .channels_max = 2,
> .rates = SNDRV_PCM_RATE_8000_96000,
> .formats = SNDRV_PCM_FMTBIT_S16_LE,
>
On imx27_3ds board:
Tested-by: Gaëtan Carlier <gcembed@gmail.com>
Regards,
Gaëtan Carlier
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2012-08-08 12:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 19:51 [PATCH v2] ASoC: imx-ssi: Remove mono support Fabio Estevam
2012-08-08 13:18 ` Gaëtan Carlier [this message]
2012-08-08 13:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5022672E.8080502@gmail.com \
--to=gcembed@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).