alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel <alsa-devel@alsa-project.org>
Subject: Re: [Bug 46011] Capture of sound from USB connected audio card (UGM96) doesn't work in 3.5.1 - kernel bug generated: scheduling while atomic
Date: Thu, 16 Aug 2012 12:28:13 +0200	[thread overview]
Message-ID: <502CCB3D.3070506@gmail.com> (raw)
In-Reply-To: <s5htxw4xwt7.wl%tiwai@suse.de>

On 15.08.2012 12:40, Takashi Iwai wrote:
>>> Could you try the patch below?

Clemens, the patch below fixes a "sleeping while atomic" bug in the USB
audio driver, but it raises a new "not enough bandwidth" issue, which
might even be unreleated.

I currently don't see the root cause here, but I might be blind. Do you
have any idea?


Thanks,
Daniel


> ---
> From: Takashi Iwai <tiwai@suse.de>
> Subject: [PATCH] ALSA: usb-audio: Fix scheduling-while-atomic bug in PCM
>  capture stream
> 
> A PCM capture stream on usb-audio causes a scheduling-while-atomic
> BUG, as reported in the bugzilla entry below.  It's because
> snd_usb_endpoint_start() is called at first at trigger START for a
> capture stream, and this function contains the left-over EP
> deactivation codes.  The problem doesn't happen for a playback stream
> because the function is called at PCM prepare time, which can sleep.
> 
> This patch fixes the BUG by moving the EP deactivation code into the
> PCM prepare callback.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=46011
> Cc: <stable@vger.kernel.org> [v3.5+]
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  sound/usb/endpoint.c | 4 ----
>  sound/usb/pcm.c      | 3 +++
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
> index 0f647d2..c411812 100644
> --- a/sound/usb/endpoint.c
> +++ b/sound/usb/endpoint.c
> @@ -821,10 +821,6 @@ int snd_usb_endpoint_start(struct snd_usb_endpoint *ep)
>  	if (++ep->use_count != 1)
>  		return 0;
>  
> -	/* just to be sure */
> -	deactivate_urbs(ep, 0, 1);
> -	wait_clear_urbs(ep);
> -
>  	ep->active_mask = 0;
>  	ep->unlink_mask = 0;
>  	ep->phase = 0;
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index a1298f3..62ec808 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -544,6 +544,9 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream *substream)
>  	subs->last_frame_number = 0;
>  	runtime->delay = 0;
>  
> +	/* clear the pending deactivation on the target EPs */
> +	deactivate_endpoints(subs);
> +
>  	/* for playback, submit the URBs now; otherwise, the first hwptr_done
>  	 * updates for all URBs would happen at the same time when starting */
>  	if (subs->direction == SNDRV_PCM_STREAM_PLAYBACK)
> 

       reply	other threads:[~2012-08-16  9:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-46011-47592@https.bugzilla.kernel.org/>
     [not found] ` <20120815103121.D4D5211FC6C@bugzilla.kernel.org>
     [not found]   ` <502B7B5B.1030808@gmail.com>
     [not found]     ` <s5htxw4xwt7.wl%tiwai@suse.de>
2012-08-16 10:28       ` Daniel Mack [this message]
2012-08-16 11:26         ` [Bug 46011] Capture of sound from USB connected audio card (UGM96) doesn't work in 3.5.1 - kernel bug generated: scheduling while atomic Clemens Ladisch
2012-08-17  6:17           ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502CCB3D.3070506@gmail.com \
    --to=zonque@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).