alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Daniel Mack <zonque@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel <alsa-devel@alsa-project.org>
Subject: Re: [Bug 46011] Capture of sound from USB connected audio card (UGM96) doesn't work in 3.5.1 - kernel bug generated: scheduling while atomic
Date: Thu, 16 Aug 2012 13:26:48 +0200	[thread overview]
Message-ID: <502CD8F8.50008@ladisch.de> (raw)
In-Reply-To: <502CCB3D.3070506@gmail.com>

Daniel Mack wrote:
> Clemens, the patch below fixes a "sleeping while atomic" bug in the USB
> audio driver, but it raises a new "not enough bandwidth" issue, which
> might even be unreleated.
>
>> +++ b/sound/usb/pcm.c
>> @@ -544,6 +544,9 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream *substream)
>>
>> +	/* clear the pending deactivation on the target EPs */
>> +	deactivate_endpoints(subs);

The HC drivers calculate bandwidth for a stream when the first URB is
submitted or the last one is completed.  (xHCI does this when the
altsetting is changed; IIRC there are plans to have other HCDs do the
same.)

This patch doesn't change the relative order of URB submissions and
cancellations.  The descriptions in bug 46011 indicates that we're
running into the not-completely-fixed EHCI scheduling bugs.


Regards,
Clemens

  reply	other threads:[~2012-08-16 10:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-46011-47592@https.bugzilla.kernel.org/>
     [not found] ` <20120815103121.D4D5211FC6C@bugzilla.kernel.org>
     [not found]   ` <502B7B5B.1030808@gmail.com>
     [not found]     ` <s5htxw4xwt7.wl%tiwai@suse.de>
2012-08-16 10:28       ` [Bug 46011] Capture of sound from USB connected audio card (UGM96) doesn't work in 3.5.1 - kernel bug generated: scheduling while atomic Daniel Mack
2012-08-16 11:26         ` Clemens Ladisch [this message]
2012-08-17  6:17           ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502CD8F8.50008@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).