From: Jaroslav Kysela <perex@perex.cz>
To: Vinod Koul <vinod.koul@linux.intel.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
broonie@opensource.wolfsonmicro.com, lrg@ti.com
Subject: Re: [PATCH 1/3] ALSA: pcm - introduce device_buffer
Date: Fri, 31 Aug 2012 12:48:53 +0200 [thread overview]
Message-ID: <50409695.1060904@perex.cz> (raw)
In-Reply-To: <1346375684-4145-2-git-send-email-vinod.koul@linux.intel.com>
Date 31.8.2012 03:14, Vinod Koul wrote:
> - if (avail >= runtime->stop_threshold) {
> + snd_pcm_uframes_t actual_avail;
> + if (avail < runtime->device_buffer)
> + actual_avail = avail;
> + else
> + actual_avail = avail - runtime->device_buffer;
> + if (actual_avail >= runtime->stop_threshold) {
Perhaps this may be simplified to:
if (avail >= runtime->stop_threshold + runtime->device_buffer)
> + snd_printd(KERN_ERR "avail > stop_threshold!!\n");
> + snd_printd(KERN_ERR "actual_avail %ld, avail %ld, device_buffer %ld!!\n",
> + actual_avail, avail, runtime->device_buffer);
I would propose to enhance xrun_log() to show something about
device_buffer and remove these printd calls from this location.
Jaroslav
--
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project; Red Hat, Inc.
next prev parent reply other threads:[~2012-08-31 10:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 1:14 [PATCH v3 0/3] introduce device_buffer Vinod Koul
2012-08-31 1:14 ` [PATCH 1/3] ALSA: pcm - " Vinod Koul
2012-08-31 2:06 ` Raymond Yau
2012-08-31 15:05 ` Vinod Koul
2012-08-31 10:48 ` Jaroslav Kysela [this message]
2012-08-31 15:02 ` Vinod Koul
2012-08-31 1:14 ` [PATCH 2/3] ASoC: add device_buffer in asoc Vinod Koul
2012-08-31 1:14 ` [PATCH 3/3] ASoC: mid-x86 - implement buffer query in sst_platform driver Vinod Koul
2012-08-31 10:41 ` [PATCH v3 0/3] introduce device_buffer Jaroslav Kysela
2012-08-31 14:53 ` Vinod Koul
2012-09-04 14:24 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2012-08-30 19:12 [PATCH " Vinod Koul
2012-08-30 19:12 ` [PATCH 1/3] ALSA: pcm - " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50409695.1060904@perex.cz \
--to=perex@perex.cz \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).