[PATCH 0/3] ALSA: snd-usb: Regression fixes for 3.5

[PATCH 0/3] ALSA: snd-usb: Regression fixes for 3.5

[Daniel Mack]

Here are 3 more regression fixes for snd-usb in 3.5. It's annoying
they haven't been found earlier, but at least we're now back to the
streaming quality we had before the streaming refactoring.

Anyone with a USB device, please give it a quick shot at least.

Thanks,
Daniel


Daniel Mack (3):
  ALSA: snd-usb: restore delay information
  ALSA: snd-usb: fix calls to next_packet_size
  ALSA: snd-usb: fix cross-interface streaming devices

 sound/usb/endpoint.c | 13 +------------
 sound/usb/endpoint.h |  1 +
 sound/usb/pcm.c      | 51 +++++++++++++++++++++++++++++++++++++++++++++++----
 3 files changed, 49 insertions(+), 16 deletions(-)

-- 
1.7.11.4

Re: [PATCH 0/3] ALSA: snd-usb: Regression fixes for 3.5

[☈king]

I am having the following symptoms, before and after application of this
thread's patches:

Given:
- An onboard card
- A Logitech h390 USB headset
- alsa-info of: http://www.alsa-project.org/db/?f=942b5e96b53a667270f895ec5061ca14af0339ee

When:
- I do: aplay $(locate .wav | grep Front)
  it outputs:
  alsa ALSA lib pcm_direct.c:980:(snd1_pcm_direct_initialize_slave)
unable to install hw params
  ALSA lib pcm_dmix.c:1030:(snd_pcm_dmix_open) unable to initialize slave
  aplay: main:682: audio open error: Broken pipe
- I do a Skype "Make a test sound"
  /var/log/messages streams dozens of these:
  kernel: cannot submit urb 0, error -28: not enough bandwidth

Note that this is a new laptop and headset, so I haven't compared how
either works on other setups, such as with other kernels or alsa versions.

Any hints? Any further info needed?

Thanks!
—☈

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH 0/3] ALSA: snd-usb: Regression fixes for 3.5

[Takashi Iwai]

At Thu, 30 Aug 2012 18:52:28 +0200,
Daniel Mack wrote:
> 
> Here are 3 more regression fixes for snd-usb in 3.5. It's annoying
> they haven't been found earlier, but at least we're now back to the
> streaming quality we had before the streaming refactoring.
> 
> Anyone with a USB device, please give it a quick shot at least.

I have no device right now during traveling, so ping me if you got a
positive report or you tested by yourself.  Then I'll merge and send
the pull request in the next week.


thanks,

Takashi

> 
> Thanks,
> Daniel
> 
> 
> Daniel Mack (3):
>   ALSA: snd-usb: restore delay information
>   ALSA: snd-usb: fix calls to next_packet_size
>   ALSA: snd-usb: fix cross-interface streaming devices
> 
>  sound/usb/endpoint.c | 13 +------------
>  sound/usb/endpoint.h |  1 +
>  sound/usb/pcm.c      | 51 +++++++++++++++++++++++++++++++++++++++++++++++----
>  3 files changed, 49 insertions(+), 16 deletions(-)
> 
> -- 
> 1.7.11.4
> 

Re: [PATCH 0/3] ALSA: snd-usb: Regression fixes for 3.5

[Daniel Mack]

On 31.08.2012 18:26, Takashi Iwai wrote:
> At Thu, 30 Aug 2012 18:52:28 +0200,
> Daniel Mack wrote:
>>
>> Here are 3 more regression fixes for snd-usb in 3.5. It's annoying
>> they haven't been found earlier, but at least we're now back to the
>> streaming quality we had before the streaming refactoring.
>>
>> Anyone with a USB device, please give it a quick shot at least.
> 
> I have no device right now during traveling, so ping me if you got a
> positive report or you tested by yourself.  Then I'll merge and send
> the pull request in the next week.

Well, I tested them extensively after I experienced the regressions when
stress-testing my devices under PureData with very low latencies. I'm
very sure all three fixes are correct. If you agree, just apply them.
But we can as well wait until next week. Maybe people find more time for
testing over the weekend :)


Thanks,
Daniel

Re: [PATCH 0/3] ALSA: snd-usb: Regression fixes for 3.5

[Daniel Mack]

On 31.08.2012 14:59, ☈king wrote:
> I am having the following symptoms, before and after application of this
> thread's patches:
> 
> Given:
> - An onboard card
> - A Logitech h390 USB headset
> - alsa-info of: http://www.alsa-project.org/db/?f=942b5e96b53a667270f895ec5061ca14af0339ee
> 
> When:
> - I do: aplay $(locate .wav | grep Front)
>   it outputs:
>   alsa ALSA lib pcm_direct.c:980:(snd1_pcm_direct_initialize_slave)
> unable to install hw params
>   ALSA lib pcm_dmix.c:1030:(snd_pcm_dmix_open) unable to initialize slave
>   aplay: main:682: audio open error: Broken pipe
> - I do a Skype "Make a test sound"
>   /var/log/messages streams dozens of these:
>   kernel: cannot submit urb 0, error -28: not enough bandwidth
> 
> Note that this is a new laptop and headset, so I haven't compared how
> either works on other setups, such as with other kernels or alsa versions.
> 
> Any hints? Any further info needed?

What kernel do you work on? Did you try the other patch that I sent some
days ago and that already went mainline?


https://git.kernel.org/?p=linux/kernel/git/tiwai/sound.git;a=commit;h=015618b902ae8e28705b7af9b4668615fea48ddd


_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH 0/3] ALSA: snd-usb: Regression fixes for 3.5

[Daniel Mack]

On 31.08.2012 14:59, ☈king wrote:
> I am having the following symptoms, before and after application of this
> thread's patches:
> 
> Given:
> - An onboard card
> - A Logitech h390 USB headset
> - alsa-info of: http://www.alsa-project.org/db/?f=942b5e96b53a667270f895ec5061ca14af0339ee
> 
> When:
> - I do: aplay $(locate .wav | grep Front)
>   it outputs:
>   alsa ALSA lib pcm_direct.c:980:(snd1_pcm_direct_initialize_slave)
> unable to install hw params
>   ALSA lib pcm_dmix.c:1030:(snd_pcm_dmix_open) unable to initialize slave
>   aplay: main:682: audio open error: Broken pipe
> - I do a Skype "Make a test sound"
>   /var/log/messages streams dozens of these:
>   kernel: cannot submit urb 0, error -28: not enough bandwidth
> 
> Note that this is a new laptop and headset, so I haven't compared how
> either works on other setups, such as with other kernels or alsa versions.
> 
> Any hints? Any further info needed?

What kernel do you work on? Did you try the other patch that I sent some
days ago and that already went mainline?


https://git.kernel.org/?p=linux/kernel/git/tiwai/sound.git;a=commit;h=015618b902ae8e28705b7af9b4668615fea48ddd


_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH 0/3] ALSA: snd-usb: Regression fixes for 3.5

[Felix Homann]

Hi,

Am 31.08.2012 18:30 schrieb "Daniel Mack" <zonque@gmail.com>:
> But we can as well wait until next week. Maybe people find more time for
> testing over the weekend :)

I won't be able to test this patch set before Wednesday.

Re: [PATCH 0/3] ALSA: snd-usb: Regression fixes for 3.5

[Daniel Mack]

(please don't drop mailing lists from Cc:)

On 31.08.2012 18:18, ☈king wrote:
> On 08/31/2012 12:15 PM, Daniel Mack wrote:
>> What kernel do you work on? Did you try the other patch that I sent
>> some days ago and that already went mainline?
>> https://git.kernel.org/?p=linux/kernel/git/tiwai/sound.git;a=commit;h=015618b902ae8e28705b7af9b4668615fea48ddd
> 
> Hrm.
> 
> I am using Gentoo's kernel from gentoo-sources. When I wrote the other
> mail I was on 3.5.1, but now I'm using 3.5.3, and when I apply that
> patch, I get:
> 
> 1 out of 5 hunks FAILED -- saving rejects to file sound/usb/pcm.c.rej
> % cat sound/usb/pcm.c.rej
> --- sound/usb/pcm.c
> +++ sound/usb/pcm.c
> @@ -544,13 +544,10 @@
>      subs->last_frame_number = 0;
>      runtime->delay = 0;
> -    /* clear the pending deactivation on the target EPs */
> -    deactivate_endpoints(subs);
> -
>      /* for playback, submit the URBs now; otherwise, the first hwptr_done
>       * updates for all URBs would happen at the same time when starting */
>      if (subs->direction == SNDRV_PCM_STREAM_PLAYBACK)
> -        return start_endpoints(subs);
> +        return start_endpoints(subs, 1);
>      return 0;
>  }
> 
> 
> It already doesn't have that deactivate_endpoints() line.
> 
> So, I manually adding the 1 arg to start_endpoints() for "can_sleep".

The important thing is not to call deactivate_endpoints() from the
prepare callback.

> Rebooting to this kernel gives the exact same results, though.

Please try a kernel built from Takashi's branch:

  https://git.kernel.org/?p=linux/kernel/git/tiwai/sound.git

That alone should fix your problem. The three patches of this series fix
some occasional stream dropouts.


Thanks for testing,
Daniel
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH 0/3] ALSA: snd-usb: Regression fixes for 3.5

[Takashi Iwai]

At Fri, 31 Aug 2012 18:30:03 +0200,
Daniel Mack wrote:
> 
> On 31.08.2012 18:26, Takashi Iwai wrote:
> > At Thu, 30 Aug 2012 18:52:28 +0200,
> > Daniel Mack wrote:
> >>
> >> Here are 3 more regression fixes for snd-usb in 3.5. It's annoying
> >> they haven't been found earlier, but at least we're now back to the
> >> streaming quality we had before the streaming refactoring.
> >>
> >> Anyone with a USB device, please give it a quick shot at least.
> > 
> > I have no device right now during traveling, so ping me if you got a
> > positive report or you tested by yourself.  Then I'll merge and send
> > the pull request in the next week.
> 
> Well, I tested them extensively after I experienced the regressions when
> stress-testing my devices under PureData with very low latencies. I'm
> very sure all three fixes are correct. If you agree, just apply them.
> But we can as well wait until next week. Maybe people find more time for
> testing over the weekend :)

FYI, I already merged these into sound git tree as it worked well with
my devices.  I'm going to send a pull request including these fixes.


Takashi