alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: David Henningsson <david.henningsson@canonical.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, 939161@bugs.launchpad.net
Subject: Re: [PATCH] ALSA: hda - Remove ignore_misc_bit
Date: Fri, 07 Sep 2012 13:26:35 +0200	[thread overview]
Message-ID: <5049D9EB.5070301@canonical.com> (raw)
In-Reply-To: <s5hligmw3s0.wl%tiwai@suse.de>

On 09/07/2012 12:01 PM, Takashi Iwai wrote:
> At Fri,  7 Sep 2012 07:25:44 +0200,
> David Henningsson wrote:
>>
>> The purpose of this flag is unclear. If the problem is that some machines
>> have broken misc/NO_PRESENCE bits, they should be fixed by pin fixups.
>>
>> In addition, this causes jack detection functionality to be flawed on
>> the M31EI, where there are two jacks without jack detection (which is
>> properly marked as NO_PRESENCE), but due to ignore_misc_bit, these
>> jacks are instead being reported as being present but always unplugged.
>>
>> BugLink: https://bugs.launchpad.net/bugs/939161
>> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
>
> So this will fix this one case but will break some others certainly.
> It's a difficult to judge, but more removal is better, so I'll take
> this.

Ok. Do you have a sense for how many machines that will regress due to 
this patch? If it is common to set all pins to the wrong value, maybe 
its the M31EI that is the exception.

> But I still wonder why PulseAudio cares the headphone jack state even
> though this has only one output at all?

When seeing the system as a whole, there can be other outputs on other 
cards - HDMI, USB etc. If somebody e g plugs a USB headset in it will be 
simpler for the user if PulseAudio does not also show the unplugged 3.5 
mm jack.



-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic

  reply	other threads:[~2012-09-07 11:26 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07  5:25 [PATCH] ALSA: hda - Remove ignore_misc_bit David Henningsson
2012-09-07 10:01 ` Takashi Iwai
2012-09-07 11:26   ` David Henningsson [this message]
2012-09-07 11:59     ` Takashi Iwai
2012-09-07 12:17       ` David Henningsson
2012-09-07 12:36         ` Takashi Iwai
2012-09-07 12:47           ` David Henningsson
2012-09-07 13:09             ` Takashi Iwai
2012-09-07 14:28               ` David Henningsson
2012-09-07 14:32                 ` Takashi Iwai
2012-09-07 15:39                   ` Tanu Kaskinen
     [not found]             ` <CAN8cciYOMpjXfEpQxYFwTve94rz_LLzJyA=nBdCCdtwOJ5Lnbw@mail.gmail.com>
2012-09-17  8:44               ` Raymond Yau
2012-09-08  1:10 ` Raymond Yau
2012-09-09  7:50   ` Takashi Iwai
2012-09-14  2:10     ` Raymond Yau
2012-09-17  7:39     ` David Henningsson
2012-09-18  8:26       ` Takashi Iwai
2012-09-18  8:40         ` David Henningsson
2012-09-18  8:58           ` Takashi Iwai
2012-09-19  0:35       ` Raymond Yau
2012-09-25 15:38         ` Raymond Yau
2012-09-19 15:20       ` Raymond Yau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5049D9EB.5070301@canonical.com \
    --to=david.henningsson@canonical.com \
    --cc=939161@bugs.launchpad.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).