alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Alsa-devel@alsa-project.org
Subject: Need help with WM8960
Date: Wed, 12 Sep 2012 18:09:00 -0500	[thread overview]
Message-ID: <5051160C.2010802@freescale.com> (raw)

Mark,

I'm trying to port some old Linux code to upstream for a third-party board
that uses a Freescale P1022 and a Wolfson WM8960. I've got audio working,
but it's using a hack from the third-party code, and I don't know how to
do implement the change properly, mostly because I don't understand DAPM.

The first problem is that I get this:

	wm8960 0-001a: No platform data supplied

What kind of platform data is the driver expecting, and how do I get it
that data?  I don't seem to need any platform data to make the code work.

Second, I uploaded the hack to wm8960.c at http://pastebin.com/RwVy6cQg

You can see that he disables the DAPM controls for DACL, DACR, ADCL, and
ADCR, and forces those bits set in the wm8960_probe function.  There's
also a comment that documents some limitations.  What is the proper way to
implement this change?

Third, in order to actually hear audio, I had to unmute the "Left Output
Mixer PCM" and "Right Output Mixer PCM".  Is this something that the
machine driver should do automatically?  And if so, how?

-- 
Timur Tabi
Linux kernel developer at Freescale

             reply	other threads:[~2012-09-12 23:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12 23:09 Timur Tabi [this message]
2012-09-13  3:13 ` Need help with WM8960 Mark Brown
2012-09-13  3:26   ` Tabi Timur-B04825
2012-09-13  3:31     ` Mark Brown
2012-09-13 14:43   ` Timur Tabi
2012-09-13 15:44     ` Timur Tabi
2012-09-13 16:29       ` Timur Tabi
2012-09-19  2:59         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5051160C.2010802@freescale.com \
    --to=timur@freescale.com \
    --cc=Alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).