From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: alsa-devel@alsa-project.org,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-omap@vger.kernel.org
Subject: Re: ASoC: Fix wrong include for McPDM
Date: Thu, 04 Oct 2012 11:03:42 +0300 [thread overview]
Message-ID: <506D42DE.7000205@ti.com> (raw)
In-Reply-To: <20121003165213.GC4840@atomide.com>
Hi Tony,
On 10/03/2012 07:52 PM, Tony Lindgren wrote:
> McPDM needs platt/cpu.h for omap_rev and not omap_hwmod.h.
> Drivers must not include omap_hwmod.h at, it will be
> private to mach-omap2 soon. Fix the problem before other
> drivers will also start including omap_hwmod.h.
>
> Note that also plat/cpu.h will be going away, so the
> omap_rev check needs to be replaced with mcpdm-watchdog
> flag from platform_data or DT.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> ---
>
> Can you guys please queue this as fix for -rc1?
>
> This removes and unnecessary dependency for making
> omap_hwmod.h local to mach-omap2.
>
> Then I'm hoping Peter will remove the plat/cpu.h
> dependency for v3.8 merge window ;)
I can remove it for 3.7 as well since there is no need for the revision check
at all.
Will send the omap-mcpdm update series for 3.7 in couple of minutes (including
this patch).
>
> --- a/sound/soc/omap/omap-mcpdm.c
> +++ b/sound/soc/omap/omap-mcpdm.c
> @@ -40,7 +40,7 @@
> #include <sound/pcm_params.h>
> #include <sound/soc.h>
>
> -#include <plat/omap_hwmod.h>
> +#include <plat/cpu.h>
> #include "omap-mcpdm.h"
> #include "omap-pcm.h"
>
>
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-10-04 8:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 16:52 ASoC: Fix wrong include for McPDM Tony Lindgren
2012-10-04 8:03 ` Peter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506D42DE.7000205@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jarkko.nikula@bitmer.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).