From: Daniel Mack <zonque@gmail.com>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH v2] ALSA: ASoC: McASP: add support for 24 bit samples
Date: Tue, 09 Oct 2012 11:47:57 +0200 [thread overview]
Message-ID: <5073F2CD.9010407@gmail.com> (raw)
In-Reply-To: <A551BDF323A45B48ACE6A404AA16A1C412786E53@TOP-EX01.TOPIC.LOCAL>
On 09.10.2012 11:41, Mike Looijmans wrote:
> Sorry for the lack of quoting, but I onle get the digest.
>
> These are wrong:
>
> + case SNDRV_PCM_FORMAT_U24_LE: + case
> SNDRV_PCM_FORMAT_S24_LE:
>
> These pack a 24-bit sample value in a 32-bit word. The codec will
> send 32 bits to the McASP, and you should transfer 32 bits to the
> user, not just 24. Hence, SNDRV_PCM_FORMAT_S24_LE must be treated
> just like SNDRV_PCM_FORMAT_S32_LE.
>
> I've tested that on a DA850-alike board with several TLV320AIC3256
> codecs, treating them as 3-byte samples will reasult in invalid
> data.
Ok, thanks for reporting this. Would like to send a patch or want me to
fix it?
Daniel
next prev parent reply other threads:[~2012-10-09 9:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 9:41 [PATCH v2] ALSA: ASoC: McASP: add support for 24 bit samples Mike Looijmans
2012-10-09 9:47 ` Daniel Mack [this message]
2012-10-09 9:49 ` Mike Looijmans
2012-10-09 10:24 ` Mark Brown
2012-10-09 11:00 ` Daniel Mack
2012-10-09 12:21 ` Clemens Ladisch
2012-10-09 12:32 ` Mark Brown
2012-10-09 13:06 ` Mike Looijmans
-- strict thread matches above, loose matches on Subject: below --
2012-10-09 7:35 Daniel Mack
2012-10-09 9:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5073F2CD.9010407@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=mike.looijmans@topic.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).