alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: Pete Leigh <pete.leigh@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: Fwd: Support for Roland VG-99 (working code, but could use help)
Date: Tue, 16 Oct 2012 09:40:29 +0200	[thread overview]
Message-ID: <507D0F6D.1000102@gmail.com> (raw)
In-Reply-To: <CABn3OEHRK7TLp+J_pZjMoFts4bZ=-FquQX0WKCzUcaaMZ8Nrpg@mail.gmail.com>

Hi Pete,

On 16.10.2012 01:59, Pete Leigh wrote:
> I tried posting this  a couple of days ago, but no response... I'm
> wondering if the (text) attachment stopped people from seeing it, or
> if there's something else I missed?

It's probably rather that people are too busy to respond :)

> It's just a request to look over the lsusb output and new quirks-table
> entry included, with a view to getting this added to a release.
> 
> Since the initial post, I've done more testing (I'm using a kernel
> based on 3.4.11-1.rt19.1.fc17.ccrma.x86_64.rt) and everything seems to
> work fine (including midi in, which I wasn't sure of at the time of
> posting)

Ok, well done :) But are you sure 44100 is the only supported sample rate?

> apart from one apparently cosmetic issue -  the device name
> no longer shows up in lsusb output, though it did before applying the
> quirk. (?)

lsusb -v should still show it. For the normal output, you could submit
an entry here: http://www.linux-usb.org/usb-ids.html

> I'll include the quirk entry as text rather than an attachment this time.
> 
> If I actually need to go through the process of generating a patch and
> sending mail via git, as per the developer page on the alsa-project
> site, could someone let me know, and I'll give it a go (it's something
> I was hoping to avoid, I admit!)

Yes, in order to prepare a proper patch, you'll have to do that please.
Check out the latestes sound.git[*] and make sure your patch applies
there. Also note that the entries in this file are sorted by VID/PID.

If you want to avoid that by all means, I can do it for you, but I can't
test it of course.


Thanks for pushing your work back to mainline!

Daniel

  reply	other threads:[~2012-10-16  7:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CABn3OEFatrnhGs1xzpmOfXSxpSLuGwgRtN8v=1B96i6=7_9vTg@mail.gmail.com>
2012-10-15 23:59 ` Fwd: Support for Roland VG-99 (working code, but could use help) Pete Leigh
2012-10-16  7:40   ` Daniel Mack [this message]
2012-10-16  8:31     ` Pete Leigh
2012-10-16  8:36       ` Daniel Mack
2012-10-18 23:38         ` Pete Leigh
2012-10-19  7:45           ` Daniel Mack
2012-10-19  8:23             ` Pete Leigh
2012-10-19  8:24               ` Daniel Mack
2012-10-19  8:49                 ` Pete Leigh
2012-10-19 17:02                   ` Pete Leigh
2012-10-19 17:46                     ` Daniel Mack
2012-10-19 18:18                       ` Pete Leigh
2012-10-19 18:21                         ` Daniel Mack
2012-10-19 22:24                       ` Pete Leigh
2012-10-20  0:17                         ` Pete Leigh
2012-10-20  2:21                           ` Pete Leigh
2012-10-16  9:19       ` Clemens Ladisch
2012-10-16 11:38         ` Pete Leigh
2012-10-16 12:27           ` Clemens Ladisch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507D0F6D.1000102@gmail.com \
    --to=zonque@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=pete.leigh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).