Linux Kernel-3.5 crashed as dapm is not supported by codec

Linux Kernel-3.5 crashed as dapm is not supported by codec

[Rajeev kumar]

Hello Peter

I am working on Linux Kernel-3.5.

I have not provided the dapm support in codec. When the system goes in 
hibernation state it gets crashed. command for putting the system in 
hibernation:

echo disk > /sys/power/state

Please find below the crash log

Unable to handle kernel NULL pointer dereference at virtual address 00000008
pgd = bd470000
[00000008] *pgd=3d43b831, *pte=00000000, *ppte=00000000
Internal error: Oops: 17 [#1] SMP ARM
Modules linked in:
CPU: 1    Not tainted  (3.5.0-lsp-3.3.0-rc1 #5)
PC is at snd_soc_dapm_shutdown+0x48/0x11c
LR is at snd_soc_poweroff+0x68/0x70
pc : [<80372438>]    lr : [<8036ccf4>]    psr: 00000013
sp : bd5bbd98  ip : bd5bbdc8  fp : bd5bbdc4
r10: 806a6048  r9 : 8044e200  r8 : bd5bbd98
r7 : 807260c4  r6 : bebceec8  r5 : ffffffec  r4 : bebcee08
r3 : 00000000  r2 : bebcec10  r1 : 00000000  r0 : 807260c4
Flags: nzcv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment user
Control: 10c53c7d  Table: 3d47004a  DAC: 00000015
Process disk.sh (pid: 1932, stack limit = 0xbd5ba2f0)
Stack: (0xbd5bbd98 to 0xbd5bc000)
bd80:                                                       bd5bbd98 
bd5bbd98
bda0: bd5bbdc4 807260c4 000016b0 00000004 00000000 8024397c bd5bbde4 
bd5bbdc8
bdc0: 8036ccf4 803723fc 8036cc8c be9b2808 be9b2808 00000000 bd5bbdf4 
bd5bbde8
bde0: 802439bc 8036cc98 bd5bbe2c bd5bbdf8 80247a28 80243988 80435b80 
8008fc18
be00: 00000000 00000000 bd5bbe2c be9b2808 00000004 be9b283c 8072359c 
00000004
be20: bd5bbe54 bd5bbe30 80248564 802479f8 806a5c98 009b2880 be9b2880 
00000000
be40: 806a6008 be9b2808 bd5bbe8c bd5bbe58 80248dac 80248450 3a87fb94 
00000023
be60: 3a87fb94 00000023 00000004 806f6e58 00000004 00000005 be863e00 
bd4a2918
be80: bd5bbea4 bd5bbe90 80249144 80248cfc 00000001 00000000 bd5bbebc 
bd5bbea8
bea0: 800590a8 802490e4 00000000 806953ac bd5bbed4 bd5bbec0 800592dc 
8005906c
bec0: bde8b000 be863f00 bd5bbefc bd5bbed8 80057444 80059194 00000005 
be863f00
bee0: bd4a2900 bd5bbf70 be863e00 bd4a2918 bd5bbf0c bd5bbf00 801e5e18 
80057394
bf00: bd5bbf3c bd5bbf10 80124f18 801e5e08 bd5bbf70 00000005 bdcd9300 
76fc6000
bf20: bd5bbf70 00000000 00000000 00000000 bd5bbf6c bd5bbf40 800cf8b0 
80124e0c
bf40: 00000000 bde7b500 00000003 bdcd9300 76fc6000 00000005 00000004 
00000000
bf60: bd5bbfa4 bd5bbf70 800cfb2c 800cf7f8 00000000 00000000 00000005 
00000000
bf80: 00000004 76f87628 00000005 76fc6000 8000e088 bd5ba000 00000000 
bd5bbfa8
bfa0: 8000dde0 800cfaec 76f87628 00000005 00000001 76fc6000 00000005 
00000000
bfc0: 76f87628 00000005 76fc6000 00000004 00000005 76fc74c0 000b0094 
0005dae8
bfe0: 00000005 7e8df7c8 76ed713c 76f1fafc 60000010 00000001 3fffe821 
3fffec21
[<80372438>] (snd_soc_dapm_shutdown+0x48/0x11c) from [<8036ccf4>] 
(snd_soc_poweroff+0x68/0x70)
[<8036ccf4>] (snd_soc_poweroff+0x68/0x70) from [<802439bc>] 
(platform_pm_poweroff+0x40/0x58)
[<802439bc>] (platform_pm_poweroff+0x40/0x58) from [<80247a28>] 
(dpm_run_callback.isra.12+0x3c/0x74)
[<80247a28>] (dpm_run_callback.isra.12+0x3c/0x74) from [<80248564>] 
(__device_suspend+0x120/0x194)
[<80248564>] (__device_suspend+0x120/0x194) from [<80248dac>] 
(dpm_suspend+0xbc/0x224)
[<80248dac>] (dpm_suspend+0xbc/0x224) from [<80249144>] 
(dpm_suspend_start+0x6c/0x74)
[<80249144>] (dpm_suspend_start+0x6c/0x74) from [<800590a8>] 
(hibernation_platform_enter+0x48/0x128)
[<800590a8>] (hibernation_platform_enter+0x48/0x128) from [<800592dc>] 
(hibernate+0x154/0x21c)
[<800592dc>] (hibernate+0x154/0x21c) from [<80057444>] 
(state_store+0xbc/0xd0)
[<80057444>] (state_store+0xbc/0xd0) from [<801e5e18>] 
(kobj_attr_store+0x1c/0x28)
[<801e5e18>] (kobj_attr_store+0x1c/0x28) from [<80124f18>] 
(sysfs_write_file+0x118/0x14c)
[<80124f18>] (sysfs_write_file+0x118/0x14c) from [<800cf8b0>] 
(vfs_write+0xc4/0x140)
[<800cf8b0>] (vfs_write+0xc4/0x140) from [<800cfb2c>] (sys_write+0x4c/0x78)
[<800cfb2c>] (sys_write+0x4c/0x78) from [<8000dde0>] 
(ret_fast_syscall+0x0/0x48)
Code: e59350f8 e3a03000 e2455014 ea00000f (e595201c)

Best Regards
Rajeev

Re: Linux Kernel-3.5 crashed as dapm is not supported by codec

[Mark Brown]

On Thu, Sep 20, 2012 at 04:46:27PM +0530, Rajeev kumar wrote:

> I have not provided the dapm support in codec. When the system goes
> in hibernation state it gets crashed. command for putting the system
> in hibernation:

DAPM is mandatory now, though any device with an audio interface
connected should have some DAPM widgets added transparently so its not
always explicitly present in the CODEC driver.  It's just causing too
much pain to special case non-DAPM devices and theres really not any
cases where there's no need for widgets.

Re: Linux Kernel-3.5 crashed as dapm is not supported by codec

[Rajeev kumar]

Hello Mark,

On 9/20/2012 5:19 PM, Mark Brown wrote:
> On Thu, Sep 20, 2012 at 04:46:27PM +0530, Rajeev kumar wrote:
>
>> I have not provided the dapm support in codec. When the system goes
>> in hibernation state it gets crashed. command for putting the system
>> in hibernation:
>
> DAPM is mandatory now, though any device with an audio interface
> connected should have some DAPM widgets added transparently so its not
> always explicitly present in the CODEC driver.  It's just causing too
> much pain to special case non-DAPM devices and theres really not any
> cases where there's no need for widgets.
>

Is DAPM operates on event? In my device event generation is not 
there.Please correct me if I am wrong.

Are there some dummy interface for DAPM? What are those interfaces?

Best Regards
Rajeev

Re: Linux Kernel-3.5 crashed as dapm is not supported by codec

[Mark Brown]

On Fri, Sep 21, 2012 at 09:27:47AM +0530, Rajeev kumar wrote:
> On 9/20/2012 5:19 PM, Mark Brown wrote:

> >DAPM is mandatory now, though any device with an audio interface
> >connected should have some DAPM widgets added transparently so its not
> >always explicitly present in the CODEC driver.  It's just causing too
> >much pain to special case non-DAPM devices and theres really not any
> >cases where there's no need for widgets.

> Is DAPM operates on event? In my device event generation is not
> there.Please correct me if I am wrong.

I can't parse the above, sorry.  Please clarify your question.

> Are there some dummy interface for DAPM? What are those interfaces?

No, DAPM is just there.

Re: Linux Kernel-3.5 crashed as dapm is not supported by codec

[Rajeev kumar]

Hello Mark,

On 9/21/2012 9:27 AM, Rajeev kumar wrote:
> Hello Mark,
>
> On 9/20/2012 5:19 PM, Mark Brown wrote:
>> On Thu, Sep 20, 2012 at 04:46:27PM +0530, Rajeev kumar wrote:
>>
>>> I have not provided the dapm support in codec. When the system goes
>>> in hibernation state it gets crashed. command for putting the system
>>> in hibernation:
>>
>> DAPM is mandatory now, though any device with an audio interface
>> connected should have some DAPM widgets added transparently so its not
>> always explicitly present in the CODEC driver. It's just causing too
>> much pain to special case non-DAPM devices and theres really not any
>> cases where there's no need for widgets.
>>
>

Once again I am raising this issue. Sorry for that.
First time I have implemented dapm support for my codec driver (sta529), 
but still crash is there. There is no any asynchronous events, so 
platform/Machine driver does not contains any dapm widgets.

Please find below the implementation for dapm.

static const struct snd_soc_dapm_widget sta529_dapm_widgets[] = {
         SND_SOC_DAPM_DAC("DAC", "Play", SND_SOC_NOPM , 0, 0),
         SND_SOC_DAPM_ADC("ADC", "Capture", SND_SOC_NOPM, 0, 0),
         SND_SOC_DAPM_OUTPUT("HPL"),
         SND_SOC_DAPM_OUTPUT("HPR"),
         SND_SOC_DAPM_OUTPUT("SPKL"),
         SND_SOC_DAPM_OUTPUT("SPKR"),
         SND_SOC_DAPM_INPUT("MIC1"),
};

static const struct snd_soc_dapm_route sta529_audio_map[] = {
         {"DAC", NULL, "output"},
         {"ADC", NULL, "input"},
         {"HPL", NULL, "HP Left Out"},
         {"HPR", NULL, "HP Right Out"},
         {"SPKL", NULL, "SPK Left Out"},
         {"SPKR", NULL, "SPK Right Out"},
   };
struct snd_soc_codec_driver sta529_codec_driver = {
         .probe = sta529_probe,
         .remove = sta529_remove,
         .set_bias_level = sta529_set_bias_level,
         .suspend = sta529_suspend,
         .resume = sta529_resume,
         .controls = sta529_snd_controls,
         .num_controls = ARRAY_SIZE(sta529_snd_controls),
         .dapm_widgets = sta529_dapm_widgets,
         .num_dapm_widgets = ARRAY_SIZE(sta529_dapm_widgets),
         .dapm_routes = sta529_audio_map,
         .num_dapm_routes = ARRAY_SIZE(sta529_audio_map),
};


Could you please suggest me, is there any thing more I need to do to 
make it work or I am missing something.

For reference, please find crash log also.

snd_soc_dapm_shutdown+0x4c/0x11c) from [<803ce05c>] 
(snd_soc_poweroff+0x68/0x70)
[<803ce05c>] (snd_soc_poweroff+0x68/0x70) from [<80288b1c>] 
(platform_pm_poweroff+0x40/0x58)
[<80288b1c>] (platform_pm_poweroff+0x40/0x58) from [<8028d1a8>] 
(dpm_run_callback.isra.4+0x3c/0x74)
[<8028d1a8>] (dpm_run_callback.isra.4+0x3c/0x74) from [<8028dbcc>] 
(__device_suspend+0x180/0x228)
[<8028dbcc>] (__device_suspend+0x180/0x228) from [<8028e5d4>] 
(dpm_suspend+0xb4/0x220)
[<8028e5d4>] (dpm_suspend+0xb4/0x220) from [<8028e97c>] 
(dpm_suspend_start+0x6c/0x74)
[<8028e97c>] (dpm_suspend_start+0x6c/0x74) from [<8005b778>] 
(hibernation_platform_enter+0x48/0x128)
[<8005b778>] (hibernation_platform_enter+0x48/0x128) from [<8005b9ac>] 
(hibernate+0x154/0x21c)
[<8005b9ac>] (hibernate+0x154/0x21c) from [<80059b10>] 
(state_store+0xbc/0xd0)
[<80059b10>] (state_store+0xbc/0xd0) from [<801f093c>] 
(kobj_attr_store+0x1c/0x28)
[<801f093c>] (kobj_attr_store+0x1c/0x28) from [<80127bd0>] 
(sysfs_write_file+0x118/0x14c)
[<80127bd0>] (sysfs_write_file+0x118/0x14c) from [<800d2640>] 
(vfs_write+0xc4/0x140)
[<800d2640>] (vfs_write+0xc4/0x140) from [<800d28bc>] (sys_write+0x4c/0x78)
[<800d28bc>] (sys_write+0x4c/0x78) from [<8000de20>] 
(ret_fast_syscall+0x0/0x48)
Code: e59350f8 e3a03000 e2455014 ea00000f (e595201c)


Best Regards
Rajeev

> Best Regards
> Rajeev
>
>
>
>

Re: Linux Kernel-3.5 crashed as dapm is not supported by codec

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 1248 bytes --]

On Tue, Nov 06, 2012 at 04:10:41PM +0530, Rajeev kumar wrote:

> Once again I am raising this issue. Sorry for that.
> First time I have implemented dapm support for my codec driver
> (sta529), but still crash is there. There is no any asynchronous
> events, so platform/Machine driver does not contains any dapm
> widgets.

This is probably a bug in your system given that nobody else is seeing
it, I'd suggest you follow normal debugging processes to figure out
where the crash is occuring.  Just a backtrace isn't really enough to
provide useful diagnostic information (especially without the
translation to line numbers), you should at least turn on logging and
also translate the backtrace into line numbers.

> 
> Please find below the implementation for dapm.
> 
> static const struct snd_soc_dapm_widget sta529_dapm_widgets[] = {
>         SND_SOC_DAPM_DAC("DAC", "Play", SND_SOC_NOPM , 0, 0),
>         SND_SOC_DAPM_ADC("ADC", "Capture", SND_SOC_NOPM, 0, 0),
>         SND_SOC_DAPM_OUTPUT("HPL"),
>         SND_SOC_DAPM_OUTPUT("HPR"),
>         SND_SOC_DAPM_OUTPUT("SPKL"),
>         SND_SOC_DAPM_OUTPUT("SPKR"),
>         SND_SOC_DAPM_INPUT("MIC1"),
> };

Does the device really have no power control at all?

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: Linux Kernel-3.5 crashed as dapm is not supported by codec

[Rajeev kumar]

Hello Mark,

On 11/6/2012 5:13 PM, Mark Brown wrote:
> On Tue, Nov 06, 2012 at 04:10:41PM +0530, Rajeev kumar wrote:
>
>> Once again I am raising this issue. Sorry for that.
>> First time I have implemented dapm support for my codec driver
>> (sta529), but still crash is there. There is no any asynchronous
>> events, so platform/Machine driver does not contains any dapm
>> widgets.
>
> This is probably a bug in your system given that nobody else is seeing
> it, I'd suggest you follow normal debugging processes to figure out
> where the crash is occuring.  Just a backtrace isn't really enough to
> provide useful diagnostic information (especially without the
> translation to line numbers), you should at least turn on logging and
> also translate the backtrace into line numbers.
>

Turn on logging does not helping in giving any extra information in this 
case. Backtracing the code gives me the line number. Please find below 
the information.

The problem occur only when I want to put system into hibernation 
otherwise it is working fine.
When the system put into hibernation mode snd_soc_dapm_shutdown  routine 
is called from snd_soc_poweroff function.

static void soc_dapm_shutdown_codec(struct snd_soc_dapm_context *dapm)
3540 {
3541         struct snd_soc_dapm_widget *w;
3542         LIST_HEAD(down_list);
3543         int powerdown = 0;
3544
3545         list_for_each_entry(w, &dapm->card->widgets, list) {
3546                 if (w->dapm != dapm)
3547                         continue;
3548                 if (w->power) {
3549                         dapm_seq_insert(w, &down_list, false);
3550                         w->power = 0;
3551                         powerdown = 1;
3552                 }
3553         }


If you check line number 3545, it is trying to get widget from card.
and the system get crashed as there is no entry for dapm in the card.

As I mentioned previously, I have provided widgets support only at codec 
level not at platform/machine level. So extracting widgets from card may 
create an issue.

Note:
Just to make an experiment, I have added a single widget in machine 
driver then also I am getting the same crash log.

>>
>> Please find below the implementation for dapm.
>>
>> static const struct snd_soc_dapm_widget sta529_dapm_widgets[] = {
>>          SND_SOC_DAPM_DAC("DAC", "Play", SND_SOC_NOPM , 0, 0),
>>          SND_SOC_DAPM_ADC("ADC", "Capture", SND_SOC_NOPM, 0, 0),
>>          SND_SOC_DAPM_OUTPUT("HPL"),
>>          SND_SOC_DAPM_OUTPUT("HPR"),
>>          SND_SOC_DAPM_OUTPUT("SPKL"),
>>          SND_SOC_DAPM_OUTPUT("SPKR"),
>>          SND_SOC_DAPM_INPUT("MIC1"),
>> };
>
> Does the device really have no power control at all?

I have a single bit for power bridge ONN/OFF in a given register. I am 
handling this bit with  SND_SOC_BIAS_OFF and SND_SOC_BIAS_ON.

Best Regards
Rajeev

Re: Linux Kernel-3.5 crashed as dapm is not supported by codec

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 1867 bytes --]

On Wed, Nov 07, 2012 at 11:02:21AM +0530, Rajeev kumar wrote:

> Turn on logging does not helping in giving any extra information in
> this case. Backtracing the code gives me the line number. Please
> find below the information.

Perhaps if you were to share the logging someone might spot something,
or perhaps if you thought about the logging in more detail...

> static void soc_dapm_shutdown_codec(struct snd_soc_dapm_context *dapm)
> 3540 {
> 3541         struct snd_soc_dapm_widget *w;
> 3542         LIST_HEAD(down_list);
> 3543         int powerdown = 0;
> 3544
> 3545         list_for_each_entry(w, &dapm->card->widgets, list) {
> 3546                 if (w->dapm != dapm)
> 3547                         continue;
> 3548                 if (w->power) {
> 3549                         dapm_seq_insert(w, &down_list, false);
> 3550                         w->power = 0;
> 3551                         powerdown = 1;
> 3552                 }
> 3553         }

> If you check line number 3545, it is trying to get widget from card.
> and the system get crashed as there is no entry for dapm in the card.

Your analysis does not appear to correspond to the code.  The DAPM
context is being used to find the card here, not the other way around as
you say.  How have we managed to get an active DAPM context which isn't
part of a card?

> As I mentioned previously, I have provided widgets support only at
> codec level not at platform/machine level. So extracting widgets
> from card may create an issue.

> Note:
> Just to make an experiment, I have added a single widget in machine
> driver then also I am getting the same crash log.

So if you've tested this and found that this is not related to having
widgets in the card what is making you continually mention that you
don't have widgets in the card?  Having no widgets outside the CODEC is
totally normal.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: Linux Kernel-3.5 crashed as dapm is not supported by codec

[Rajeev kumar]

Hello Mark,

On 11/7/2012 8:26 PM, Mark Brown wrote:
> On Wed, Nov 07, 2012 at 11:02:21AM +0530, Rajeev kumar wrote:
>
>> >  Turn on logging does not helping in giving any extra information in
>> >  this case. Backtracing the code gives me the line number. Please
>> >  find below the information.
> Perhaps if you were to share the logging someone might spot something,
> or perhaps if you thought about the logging in more detail...
>
>> >  static void soc_dapm_shutdown_codec(struct snd_soc_dapm_context *dapm)
>> >  3540 {
>> >  3541         struct snd_soc_dapm_widget *w;
>> >  3542         LIST_HEAD(down_list);
>> >  3543         int powerdown = 0;
>> >  3544
>> >  3545         list_for_each_entry(w,&dapm->card->widgets, list) {
>> >  3546                 if (w->dapm != dapm)
>> >  3547                         continue;
>> >  3548                 if (w->power) {
>> >  3549                         dapm_seq_insert(w,&down_list, false);
>> >  3550                         w->power = 0;
>> >  3551                         powerdown = 1;
>> >  3552                 }
>> >  3553         }
>> >  If you check line number 3545, it is trying to get widget from card.
>> >  and the system get crashed as there is no entry for dapm in the card.
> Your analysis does not appear to correspond to the code.  The DAPM
> context is being used to find the card here, not the other way around as
> you say.  How have we managed to get an active DAPM context which isn't
> part of a card?
>

Thanks for correcting me.
Please find below the complete crash log
(The line number is same I mentioned previously for the crash).

=================================================================================================

PM: Syncing filesystems ... done.
Freezing user space processes ... (elapsed 0.05 seconds) done.
PM: Preallocating image memory... done (allocated 14310 pages)
PM: Allocated 57240 kbytes in 0.98 seconds (58.40 MB/s)
Freezing remaining freezable tasks ... (elapsed 0.02 seconds) done.
PM: freeze of devices complete after 34.208 msecs
PM: late freeze of devices complete after 1.429 msecs
PM: noirq freeze of devices complete after 2.442 msecs
Disabling non-boot CPUs ...
CPU1: shutdown
PM: Creating hibernation image:
PM: Need to copy 13838 pages
PM: Hibernation image created (13838 pages copied)
Enabling non-boot CPUs ...
CPU1: Booted secondary processor
CPU1 is up
PM: noirq thaw of devices complete after 0.885 msecs
PM: early thaw of devices complete after 0.725 msecs
eth0: device MAC address 00:10:5a:0c:fb:80
PM: thaw of devices complete after 281.477 msecs
PM: Using 1 thread(s) for compression.
PM: Compressing and saving image data (13852 pages) ...  10%
PHY: stmmac-0:01 - Link is Up - 100/Half
done
PM: Wrote 55408 kbytes in 9.63 seconds (5.75 MB/s)
PM: S|
Unable to handle kernel NULL pointer dereference at virtual address 00000008
pgd = bd470000
[00000008] *pgd=3d43b831, *pte=00000000, *ppte=00000000
Internal error: Oops: 17 [#1] SMP ARM
Modules linked in:
CPU: 1    Not tainted  (3.5.0-lsp-3.3.0-rc1 #5)
PC is at snd_soc_dapm_shutdown+0x48/0x11c
LR is at snd_soc_poweroff+0x68/0x70
pc : [<80372438>]    lr : [<8036ccf4>]    psr: 00000013
sp : bd5bbd98  ip : bd5bbdc8  fp : bd5bbdc4
r10: 806a6048  r9 : 8044e200  r8 : bd5bbd98
r7 : 807260c4  r6 : bebceec8  r5 : ffffffec  r4 : bebcee08
r3 : 00000000  r2 : bebcec10  r1 : 00000000  r0 : 807260c4
Flags: nzcv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment user
Control: 10c53c7d  Table: 3d47004a  DAC: 00000015
Process disk.sh (pid: 1932, stack limit = 0xbd5ba2f0)
Stack: (0xbd5bbd98 to 0xbd5bc000)
bd80:                                                       bd5bbd98 
bd5bbd98
bda0: bd5bbdc4 807260c4 000016b0 00000004 00000000 8024397c bd5bbde4 
bd5bbdc8
bdc0: 8036ccf4 803723fc 8036cc8c be9b2808 be9b2808 00000000 bd5bbdf4 
bd5bbde8
bde0: 802439bc 8036cc98 bd5bbe2c bd5bbdf8 80247a28 80243988 80435b80 
8008fc18
be00: 00000000 00000000 bd5bbe2c be9b2808 00000004 be9b283c 8072359c 
00000004
be20: bd5bbe54 bd5bbe30 80248564 802479f8 806a5c98 009b2880 be9b2880 
00000000
be40: 806a6008 be9b2808 bd5bbe8c bd5bbe58 80248dac 80248450 3a87fb94 
00000023
be60: 3a87fb94 00000023 00000004 806f6e58 00000004 00000005 be863e00 
bd4a2918
be80: bd5bbea4 bd5bbe90 80249144 80248cfc 00000001 00000000 bd5bbebc 
bd5bbea8
bea0: 800590a8 802490e4 00000000 806953ac bd5bbed4 bd5bbec0 800592dc 
8005906c
bec0: bde8b000 be863f00 bd5bbefc bd5bbed8 80057444 80059194 00000005 
be863f00
bee0: bd4a2900 bd5bbf70 be863e00 bd4a2918 bd5bbf0c bd5bbf00 801e5e18 
80057394
bf00: bd5bbf3c bd5bbf10 80124f18 801e5e08 bd5bbf70 00000005 bdcd9300 
76fc6000
bf20: bd5bbf70 00000000 00000000 00000000 bd5bbf6c bd5bbf40 800cf8b0 
80124e0c
bf40: 00000000 bde7b500 00000003 bdcd9300 76fc6000 00000005 00000004 
00000000
bf60: bd5bbfa4 bd5bbf70 800cfb2c 800cf7f8 00000000 00000000 00000005 
00000000
bf80: 00000004 76f87628 00000005 76fc6000 8000e088 bd5ba000 00000000 
bd5bbfa8
bfa0: 8000dde0 800cfaec 76f87628 00000005 00000001 76fc6000 00000005 
00000000
bfc0: 76f87628 00000005 76fc6000 00000004 00000005 76fc74c0 000b0094 
0005dae8
bfe0: 00000005 7e8df7c8 76ed713c 76f1fafc 60000010 00000001 3fffe821 
3fffec21
[<80372438>] (snd_soc_dapm_shutdown+0x48/0x11c) from [<8036ccf4>] 
(snd_soc_poweroff+0x68/0x70)
[<8036ccf4>] (snd_soc_poweroff+0x68/0x70) from [<802439bc>] 
(platform_pm_poweroff+0x40/0x58)
[<802439bc>] (platform_pm_poweroff+0x40/0x58) from [<80247a28>] 
(dpm_run_callback.isra.12+0x3c/0x74)
[<80247a28>] (dpm_run_callback.isra.12+0x3c/0x74) from [<80248564>] 
(__device_suspend+0x120/0x194)
[<80248564>] (__device_suspend+0x120/0x194) from [<80248dac>] 
(dpm_suspend+0xbc/0x224)
[<80248dac>] (dpm_suspend+0xbc/0x224) from [<80249144>] 
(dpm_suspend_start+0x6c/0x74)
[<80249144>] (dpm_suspend_start+0x6c/0x74) from [<800590a8>] 
(hibernation_platform_enter+0x48/0x128)
[<800590a8>] (hibernation_platform_enter+0x48/0x128) from [<800592dc>] 
(hibernate+0x154/0x21c)
[<800592dc>] (hibernate+0x154/0x21c) from [<80057444>] 
(state_store+0xbc/0xd0)
[<80057444>] (state_store+0xbc/0xd0) from [<801e5e18>] 
(kobj_attr_store+0x1c/0x28)
[<801e5e18>] (kobj_attr_store+0x1c/0x28) from [<80124f18>] 
(sysfs_write_file+0x118/0x14c)
[<80124f18>] (sysfs_write_file+0x118/0x14c) from [<800cf8b0>] 
(vfs_write+0xc4/0x140)
[<800cf8b0>] (vfs_write+0xc4/0x140) from [<800cfb2c>] (sys_write+0x4c/0x78)
[<800cfb2c>] (sys_write+0x4c/0x78) from [<8000dde0>] 
(ret_fast_syscall+0x0/0x48)
Code: e59350f8 e3a03000 e2455014 ea00000f (e595201c)
================================================================================================

If I talk only for the crash then BTW I tried to comment these lines 
(from line 3545 to 3552) of code and found no crash but the song is not 
getting resumed after hibernation.

Best Regards
Rajeev

Re: Linux Kernel-3.5 crashed as dapm is not supported by codec

[Péter Ujfalusi]

On 11/06/2012 11:40 AM, Rajeev kumar wrote:
> Please find below the implementation for dapm.
> 
> static const struct snd_soc_dapm_widget sta529_dapm_widgets[] = {
>         SND_SOC_DAPM_DAC("DAC", "Play", SND_SOC_NOPM , 0, 0),
>         SND_SOC_DAPM_ADC("ADC", "Capture", SND_SOC_NOPM, 0, 0),
>         SND_SOC_DAPM_OUTPUT("HPL"),
>         SND_SOC_DAPM_OUTPUT("HPR"),
>         SND_SOC_DAPM_OUTPUT("SPKL"),
>         SND_SOC_DAPM_OUTPUT("SPKR"),
>         SND_SOC_DAPM_INPUT("MIC1"),
> };
> 
> static const struct snd_soc_dapm_route sta529_audio_map[] = {
>         {"DAC", NULL, "output"},
>         {"ADC", NULL, "input"},
>         {"HPL", NULL, "HP Left Out"},
>         {"HPR", NULL, "HP Right Out"},
>         {"SPKL", NULL, "SPK Left Out"},
>         {"SPKR", NULL, "SPK Right Out"},
> };

If this is all you have for DAPM routing I just wonder what the core will do
with these... I mean you don't appear to have valid routing: no sign of
"output", "input", "HP Left Out", etc.

But it is really odd that you can not have at least some power control bits
along the paths.

This would look odd also but at least connects the widgets:
static const struct snd_soc_dapm_route sta529_audio_map[] = {
        {"HPL", NULL, "DAC"},
        {"HPR", NULL, "DAC"},
        {"ADC", NULL, "MIC1"},
};

Don't you have messages during boot or module loading about DAPM route error?

-- 
Péter

Re: Linux Kernel-3.5 crashed as dapm is not supported by codec

[Misael Lopez]

Hi Rajeev,

On 11/07/2012 10:28 PM, Rajeev kumar wrote:
<snip>

> Unable to handle kernel NULL pointer dereference at virtual address
> 00000008
> pgd = bd470000
> [00000008] *pgd=3d43b831, *pte=00000000, *ppte=00000000
> Internal error: Oops: 17 [#1] SMP ARM
> Modules linked in:
> CPU: 1    Not tainted  (3.5.0-lsp-3.3.0-rc1 #5)
> PC is at snd_soc_dapm_shutdown+0x48/0x11c
> LR is at snd_soc_poweroff+0x68/0x70
> pc : [<80372438>]    lr : [<8036ccf4>]    psr: 00000013
> sp : bd5bbd98  ip : bd5bbdc8  fp : bd5bbdc4
> r10: 806a6048  r9 : 8044e200  r8 : bd5bbd98
> r7 : 807260c4  r6 : bebceec8  r5 : ffffffec  r4 : bebcee08
> r3 : 00000000  r2 : bebcec10  r1 : 00000000  r0 : 807260c4
> Flags: nzcv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment user
> Control: 10c53c7d  Table: 3d47004a  DAC: 00000015
> Process disk.sh (pid: 1932, stack limit = 0xbd5ba2f0)
> Stack: (0xbd5bbd98 to 0xbd5bc000)
> bd80:                                                       bd5bbd98
> bd5bbd98
> bda0: bd5bbdc4 807260c4 000016b0 00000004 00000000 8024397c bd5bbde4
> bd5bbdc8
> bdc0: 8036ccf4 803723fc 8036cc8c be9b2808 be9b2808 00000000 bd5bbdf4
> bd5bbde8
> bde0: 802439bc 8036cc98 bd5bbe2c bd5bbdf8 80247a28 80243988 80435b80
> 8008fc18
> be00: 00000000 00000000 bd5bbe2c be9b2808 00000004 be9b283c 8072359c
> 00000004
> be20: bd5bbe54 bd5bbe30 80248564 802479f8 806a5c98 009b2880 be9b2880
> 00000000
> be40: 806a6008 be9b2808 bd5bbe8c bd5bbe58 80248dac 80248450 3a87fb94
> 00000023
> be60: 3a87fb94 00000023 00000004 806f6e58 00000004 00000005 be863e00
> bd4a2918
> be80: bd5bbea4 bd5bbe90 80249144 80248cfc 00000001 00000000 bd5bbebc
> bd5bbea8
> bea0: 800590a8 802490e4 00000000 806953ac bd5bbed4 bd5bbec0 800592dc
> 8005906c
> bec0: bde8b000 be863f00 bd5bbefc bd5bbed8 80057444 80059194 00000005
> be863f00
> bee0: bd4a2900 bd5bbf70 be863e00 bd4a2918 bd5bbf0c bd5bbf00 801e5e18
> 80057394
> bf00: bd5bbf3c bd5bbf10 80124f18 801e5e08 bd5bbf70 00000005 bdcd9300
> 76fc6000
> bf20: bd5bbf70 00000000 00000000 00000000 bd5bbf6c bd5bbf40 800cf8b0
> 80124e0c
> bf40: 00000000 bde7b500 00000003 bdcd9300 76fc6000 00000005 00000004
> 00000000
> bf60: bd5bbfa4 bd5bbf70 800cfb2c 800cf7f8 00000000 00000000 00000005
> 00000000
> bf80: 00000004 76f87628 00000005 76fc6000 8000e088 bd5ba000 00000000
> bd5bbfa8
> bfa0: 8000dde0 800cfaec 76f87628 00000005 00000001 76fc6000 00000005
> 00000000
> bfc0: 76f87628 00000005 76fc6000 00000004 00000005 76fc74c0 000b0094
> 0005dae8
> bfe0: 00000005 7e8df7c8 76ed713c 76f1fafc 60000010 00000001 3fffe821
> 3fffec21
> [<80372438>] (snd_soc_dapm_shutdown+0x48/0x11c) from [<8036ccf4>]
> (snd_soc_poweroff+0x68/0x70)
> [<8036ccf4>] (snd_soc_poweroff+0x68/0x70) from [<802439bc>]
> (platform_pm_poweroff+0x40/0x58)
> [<802439bc>] (platform_pm_poweroff+0x40/0x58) from [<80247a28>]
> (dpm_run_callback.isra.12+0x3c/0x74)
> [<80247a28>] (dpm_run_callback.isra.12+0x3c/0x74) from [<80248564>]
> (__device_suspend+0x120/0x194)
> [<80248564>] (__device_suspend+0x120/0x194) from [<80248dac>]
> (dpm_suspend+0xbc/0x224)
> [<80248dac>] (dpm_suspend+0xbc/0x224) from [<80249144>]
> (dpm_suspend_start+0x6c/0x74)
> [<80249144>] (dpm_suspend_start+0x6c/0x74) from [<800590a8>]
> (hibernation_platform_enter+0x48/0x128)
> [<800590a8>] (hibernation_platform_enter+0x48/0x128) from [<800592dc>]
> (hibernate+0x154/0x21c)
> [<800592dc>] (hibernate+0x154/0x21c) from [<80057444>]
> (state_store+0xbc/0xd0)
> [<80057444>] (state_store+0xbc/0xd0) from [<801e5e18>]
> (kobj_attr_store+0x1c/0x28)
> [<801e5e18>] (kobj_attr_store+0x1c/0x28) from [<80124f18>]
> (sysfs_write_file+0x118/0x14c)
> [<80124f18>] (sysfs_write_file+0x118/0x14c) from [<800cf8b0>]
> (vfs_write+0xc4/0x140)
> [<800cf8b0>] (vfs_write+0xc4/0x140) from [<800cfb2c>] (sys_write+0x4c/0x78)
> [<800cfb2c>] (sys_write+0x4c/0x78) from [<8000dde0>]
> (ret_fast_syscall+0x0/0x48)
> Code: e59350f8 e3a03000 e2455014 ea00000f (e595201c)
> ================================================================================================


The backtrace doesn't seem to point directly to codec's shutdown but
system's. There is a problem in the way the card's codec list is
traversed to perform the shutdown, please see [1]. Take a look at that
patch, it might help with this kernel crash.

Regards,
-Misa

[1]
http://mailman.alsa-project.org/pipermail/alsa-devel/2012-November/056846.html

Re: Linux Kernel-3.5 crashed as dapm is not supported by codec

[Rajeev kumar]

Hello Misael

On 11/8/2012 11:48 PM, Misael Lopez wrote:
> The backtrace doesn't seem to point directly to codec's shutdown but
> system's. There is a problem in the way the card's codec list is
> traversed to perform the shutdown, please see [1]. Take a look at that
> patch, it might help with this kernel crash.
>
> Regards,
> -Misa
>
> [1]
> http://mailman.alsa-project.org/pipermail/alsa-devel/2012-November/056846.html

Thanks for the support. The patch works fine.

In case it is not added in the tree, you can add

Tested-by: Rajeev Kumar <rajeev-dlh.kumar@st.com>

Best Regards
Rajeev

Re: Linux Kernel-3.5 crashed as dapm is not supported by codec

[Rajeev kumar]

Hello Peter,

On 11/8/2012 8:08 PM, Péter Ujfalusi wrote:
> On 11/06/2012 11:40 AM, Rajeev kumar wrote:
>> Please find below the implementation for dapm.
>>
>> static const struct snd_soc_dapm_widget sta529_dapm_widgets[] = {
>>          SND_SOC_DAPM_DAC("DAC", "Play", SND_SOC_NOPM , 0, 0),
>>          SND_SOC_DAPM_ADC("ADC", "Capture", SND_SOC_NOPM, 0, 0),
>>          SND_SOC_DAPM_OUTPUT("HPL"),
>>          SND_SOC_DAPM_OUTPUT("HPR"),
>>          SND_SOC_DAPM_OUTPUT("SPKL"),
>>          SND_SOC_DAPM_OUTPUT("SPKR"),
>>          SND_SOC_DAPM_INPUT("MIC1"),
>> };
>>
>> static const struct snd_soc_dapm_route sta529_audio_map[] = {
>>          {"DAC", NULL, "output"},
>>          {"ADC", NULL, "input"},
>>          {"HPL", NULL, "HP Left Out"},
>>          {"HPR", NULL, "HP Right Out"},
>>          {"SPKL", NULL, "SPK Left Out"},
>>          {"SPKR", NULL, "SPK Right Out"},
>> };
>
> If this is all you have for DAPM routing I just wonder what the core will do
> with these... I mean you don't appear to have valid routing: no sign of
> "output", "input", "HP Left Out", etc.
>
> But it is really odd that you can not have at least some power control bits
> along the paths.

Yes I have a single bit in a register which will do power bridge 
OFF/ONN. Right now depending on biasing level this bit is getting 
manipulated.

With the DAPM macros how can I control this bit? Please share your opinion.

>
> This would look odd also but at least connects the widgets:
> static const struct snd_soc_dapm_route sta529_audio_map[] = {
>          {"HPL", NULL, "DAC"},
>          {"HPR", NULL, "DAC"},
>          {"ADC", NULL, "MIC1"},
> };


>
> Don't you have messages during boot or module loading about DAPM route error?
>

Right now I am working on it. Yes with the given sta529_dapm_widgets and 
audio_map I am getting "Failed to add route output->DAC". I have to work 
on this.

With the sta529_audio_map suggested by you, There is no any error I am 
getting during boot time. Thanks for your valuable suggestion.

As I dont have any event based dapm control, how can I test my dapm 
support whether it is working or not?

Best Regards
Rajeev