From: Daniel Mack <zonque@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Alexander Sverdlin <subaparts@yandex.ru>
Subject: Re: [PATCH] ALSA: ASoC: cs4271: free allocated GPIO
Date: Sat, 10 Nov 2012 19:52:06 +0100 [thread overview]
Message-ID: <509EA256.6050009@gmail.com> (raw)
In-Reply-To: <20121107140720.GB28954@opensource.wolfsonmicro.com>
On 07.11.2012 15:07, Mark Brown wrote:
> On Wed, Nov 07, 2012 at 02:15:55PM +0100, Daniel Mack wrote:
>> In case of probe deferral, the allocated GPIO line is not freed, which
>> prevents it from being claimed and properly asserted in later attempts.
>>
>> Fix this by freeing the GPIO in case of errors.
>
> Can we convert to devm_gpio_request_one() instead?
>
Sure, that's much nicer.
next prev parent reply other threads:[~2012-11-10 18:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-07 13:15 [PATCH] ALSA: ASoC: cs4271: free allocated GPIO Daniel Mack
2012-11-07 14:07 ` Mark Brown
2012-11-10 18:52 ` Daniel Mack [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-10 18:52 Daniel Mack
2012-11-13 6:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509EA256.6050009@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=subaparts@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox