From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: "Reddy, M.R. Swami" <MR.Swami.Reddy@ti.com>
Cc: Vinod Koul <vinod.koul@linux.intel.com>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"Deshpande A, Vishwas" <Vishwas.A.Deshpande@ti.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Girdwood, Liam" <lrg@ti.com>
Subject: Re: [PATCH] ASoC: lm49453: Fix analog and digital volume ranges
Date: Thu, 6 Dec 2012 15:48:43 +0100 [thread overview]
Message-ID: <50C0B04B.5000701@ti.com> (raw)
In-Reply-To: <354ACD19F280E44381F0C302BC7A15A39DE2DF@DFLE08.ent.ti.com>
Hi Swami,
On 12/06/2012 09:07 AM, Reddy, M.R. Swami wrote:
> Thanks Vinod. Yes, the ADC tlvs missed... I will update the patch.
and while you are there, please fix the commit message as well.
>
> Thanks
> Swami
>
> -----Original Message-----
> From: Vinod Koul [mailto:vinod.koul@linux.intel.com]
> Sent: Thursday, December 06, 2012 12:59 AM
> To: Reddy, M.R. Swami
> Cc: broonie@opensource.wolfsonmicro.com; Girdwood, Liam; Deshpande A, Vishwas; alsa-devel@alsa-project.org
> Subject: Re: [alsa-devel] [PATCH] ASoC: lm49453: Fix analog and digital volume ranges
>
> On Wed, 2012-12-05 at 16:18 +0530, MR.Swami.Reddy@ti.com wrote:
>
>> /* TLV Declarations */
>> static const DECLARE_TLV_DB_SCALE(digital_tlv, -7650, 150, 1);
>> -static const DECLARE_TLV_DB_SCALE(port_tlv, 0, 600, 0);
>> +static const DECLARE_TLV_DB_SCALE(analog_tlv, 0, 200, 1);
> The spec says your analog gain are 0 to 30dB in steps of 2dB, this doesnt sound right to me.
>> +static const DECLARE_TLV_DB_SCALE(port_tlv, -1800, 600, 0);
>>
>> static const struct snd_kcontrol_new
>> lm49453_sidetone_mixer_controls[] = {
>> /* Sidetone supports mono only */
>> @@ -516,9 +517,9 @@ SOC_DAPM_SINGLE_TLV("Sidetone DMIC2R Volume",
>> LM49453_P0_STN_VOL_DMIC2R_REG, static const struct snd_kcontrol_new lm49453_snd_controls[] = {
>> /* mic1 and mic2 supports mono only */
>> SOC_SINGLE_TLV("Mic1 Volume", LM49453_P0_ADC_LEVELL_REG, 0, 6,
>> - 0, digital_tlv),
>> + 0, analog_tlv),
> now i see a problem.
> You have hidden the MIC gains and exposed only ADC gains. The name is wrong causing the confusion. Please make this ADC gain and add new control for MIC gain!
> Your ADC gain is -76 to 18db, with 0.5dB steps, how does this reflect that?
>
>> SOC_SINGLE_TLV("Mic2 Volume", LM49453_P0_ADC_LEVELR_REG, 0, 6,
>> - 0, digital_tlv),
>> + 0, analog_tlv),
> Ditto.....
>>
>> SOC_DOUBLE_R_TLV("DMIC1 Volume", LM49453_P0_DMIC1_LEVELL_REG,
>> LM49453_P0_DMIC1_LEVELR_REG, 0, 6, 0, digital_tlv),
>> _______________________________________________
>> Alsa-devel mailing list
>> Alsa-devel@alsa-project.org
>> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
>
> --
> ~Vinod
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
--
Péter
next prev parent reply other threads:[~2012-12-06 14:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 10:48 [PATCH] ASoC: lm49453: Fix analog and digital volume ranges MR.Swami.Reddy
2012-12-05 19:29 ` Vinod Koul
2012-12-06 8:07 ` Reddy, M.R. Swami
2012-12-06 14:48 ` Peter Ujfalusi [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-12-05 7:59 MR.Swami.Reddy
2012-12-05 8:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C0B04B.5000701@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=MR.Swami.Reddy@ti.com \
--cc=Vishwas.A.Deshpande@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=vinod.koul@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox