From: Igor Grinberg <grinberg@compulab.co.il>
To: Mike Dunn <mikedunn@newsguy.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Marek Vasut <marex@denx.de>, Eric Miao <eric.y.miao@gmail.com>,
alsa-devel@alsa-project.org,
Robert Jarzmik <robert.jarzmik@free.fr>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/3] ALSA: pxa27x: ac97 reset fixes
Date: Tue, 08 Jan 2013 10:44:55 +0200 [thread overview]
Message-ID: <50EBDC87.1030207@compulab.co.il> (raw)
In-Reply-To: <1357595714-13698-1-git-send-email-mikedunn@newsguy.com>
On 01/07/13 23:55, Mike Dunn wrote:
> AC97 reset is broken on the pxa27x. These patches fix it by addressing multiple
> problems:
> - cold reset fails because the GCR register is not set correctly
> - warm reset fails because some code used to work around a hardware bug is
> broken
> - the intent of the work-around code is obfuscated by unfortunate function
> naming
>
> This patch set replaces some earlier individual patches that had some problems.
> Thanks Robert and Igor.
>
> Changelog:
> v2:
> - don't specify the LPM flag DRIVE_HIGH in #define for the mfp config
> - patches 2 and 3 are combined into one patch
> - mfp level and direction are set only once, during driver initialization
>
> Mike Dunn (3):
> ALSA: pxa2xx: fix ac97 cold reset
> ALSA: pxa27x: fix ac97 warm reset
> ALSA: pxa27x: rename pxa27x_assert_ac97reset()
I believe all three patches should go through Mark's tree.
Mark, at least patches 1 and 2 are also stable material,
can you please, add stable tags?
Thanks.
>
> arch/arm/mach-pxa/include/mach/mfp-pxa27x.h | 3 ++
> arch/arm/mach-pxa/pxa27x.c | 24 ++++++++++++------
> sound/arm/pxa2xx-ac97-lib.c | 34 +++++++++++++++++++++-----
> 3 files changed, 46 insertions(+), 15 deletions(-)
>
--
Regards,
Igor.
next prev parent reply other threads:[~2013-01-08 8:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 21:55 [PATCH 0/3] ALSA: pxa27x: ac97 reset fixes Mike Dunn
2013-01-07 21:55 ` [PATCH 1/3] ALSA: pxa27x: fix ac97 cold reset Mike Dunn
2013-01-08 8:17 ` Igor Grinberg
2013-01-07 21:55 ` [PATCH 2/3] ALSA: pxa27x: fix ac97 warm reset Mike Dunn
2013-01-08 8:36 ` Igor Grinberg
2013-01-07 21:55 ` [PATCH 3/3] ALSA: pxa27x: rename pxa27x_assert_ac97reset() Mike Dunn
2013-01-08 8:36 ` Igor Grinberg
2013-01-08 8:44 ` Igor Grinberg [this message]
2013-01-08 11:30 ` [PATCH 0/3] ALSA: pxa27x: ac97 reset fixes Mark Brown
2013-01-08 19:16 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EBDC87.1030207@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marex@denx.de \
--cc=mikedunn@newsguy.com \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).