From: Jens Axboe <axboe@kernel.dk>
To: Takashi Iwai <tiwai@suse.de>
Cc: Eldad Zack <eldad@fogrefinery.com>,
perex@perex.cz, alsa-devel@alsa-project.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Oops in sound/usb/pcm.c:match_endpoint_audioformats() in current -git
Date: Fri, 11 Jan 2013 08:47:25 +0100 [thread overview]
Message-ID: <50EFC38D.80306@kernel.dk> (raw)
In-Reply-To: <s5hehhskcya.wl%tiwai@suse.de>
On 2013-01-10 21:19, Takashi Iwai wrote:
> From: Takashi Iwai <tiwai@suse.de>
> Subject: [PATCH v2] ALSA: usb-audio: Fix NULL dereference by access to
> non-existing substream
>
> The commit [0d9741c0: ALSA: usb-audio: sync ep init fix for
> audioformat mismatch] introduced the correction of parameters to be
> set for sync EP. But since the new code assumes that the sync EP is
> always paired with the data EP of another direction, it triggers Oops
> when a device only with a single direction is used.
>
> This patch adds a proper check of sync EP type and the presence of the
> paired substream for avoiding the crash.
>
> Reported-by: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
Confirmed, it works. You can add my tested-by too. Thanks Takashi!
--
Jens Axboe
next prev parent reply other threads:[~2013-01-11 7:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50EE7A94.60409@kernel.dk>
2013-01-10 10:21 ` Oops in sound/usb/pcm.c:match_endpoint_audioformats() in current -git Takashi Iwai
2013-01-10 12:49 ` Jens Axboe
2013-01-10 13:46 ` Takashi Iwai
2013-01-10 19:45 ` Eldad Zack
2013-01-10 20:19 ` Takashi Iwai
2013-01-10 20:26 ` Jens Axboe
2013-01-11 7:47 ` Jens Axboe [this message]
2013-01-11 10:17 ` Takashi Iwai
2013-01-11 7:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EFC38D.80306@kernel.dk \
--to=axboe@kernel.dk \
--cc=alsa-devel@alsa-project.org \
--cc=eldad@fogrefinery.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).