From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Sebastien Guiriec <s-guiriec@ti.com>
Cc: Jarkko Nikula <jarkko.nikula@bitmer.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-omap@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: omap-mcpdm: Remove useless ressource get.
Date: Mon, 11 Feb 2013 14:08:07 +0100 [thread overview]
Message-ID: <5118ED37.3070905@ti.com> (raw)
In-Reply-To: <1360587762-29072-1-git-send-email-s-guiriec@ti.com>
Hi Sebastien,
On 02/11/2013 02:02 PM, Sebastien Guiriec wrote:
> Remove unused memory ressource get from McPDM driver.
I have no idea how this remain in the driver ;)
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Sebastien Guiriec <s-guiriec@ti.com>
> ---
> sound/soc/omap/omap-mcpdm.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/sound/soc/omap/omap-mcpdm.c b/sound/soc/omap/omap-mcpdm.c
> index 2fe8be2..5ca11bd 100644
> --- a/sound/soc/omap/omap-mcpdm.c
> +++ b/sound/soc/omap/omap-mcpdm.c
> @@ -449,10 +449,6 @@ static int asoc_mcpdm_probe(struct platform_device *pdev)
> omap_mcpdm_dai_dma_params[0].port_addr = res->start + MCPDM_REG_DN_DATA;
> omap_mcpdm_dai_dma_params[1].port_addr = res->start + MCPDM_REG_UP_DATA;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (res == NULL)
> - return -ENOMEM;
> -
> res = platform_get_resource_byname(pdev, IORESOURCE_DMA, "dn_link");
> if (!res)
> return -ENODEV;
>
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-02-11 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 13:02 [PATCH] ASoC: omap-mcpdm: Remove useless ressource get Sebastien Guiriec
2013-02-11 13:08 ` Peter Ujfalusi [this message]
2013-02-11 16:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5118ED37.3070905@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jarkko.nikula@bitmer.com \
--cc=lgirdwood@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=s-guiriec@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).