From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org,
Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Subject: Re: [PATCH TINYCOMPRESS 1/14] compress: Add function to get timestamp in samples
Date: Mon, 11 Feb 2013 08:11:04 -0600 [thread overview]
Message-ID: <5118FBF8.9060804@linux.intel.com> (raw)
In-Reply-To: <20130211063448.GA3789@intel.com>
>> The compress_get_hpointer() converts the timestamp into actual
>> time. But Android needs it in samples. To avoid the inefficiency
>> of using compress_get_hpointer() and converting into time and then
>> back into samples, this change adds compress_get_tstamp() which
>> returns the raw struct snd_compr_tstamp.
> I am fine with adding new API for returning the samples, but then why return the
> raw struct. Would make sense to just get samples if that is only thing desired.
Loss of efficiency? It's not that bad really and the conversion could be
handled in tinycompress (user-space) rather than adding a new kernel
ioctl that everyone will need to implement. The htimestamp could give
you better precision than samples if a wall clock is available in the
hardware.
-Pierre
next prev parent reply other threads:[~2013-02-11 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 0:02 [PATCH TINYCOMPRESS 1/14] compress: Add function to get timestamp in samples Richard Fitzgerald
2013-02-11 6:34 ` Vinod Koul
2013-02-11 14:11 ` Pierre-Louis Bossart [this message]
2013-02-19 17:18 ` Richard Fitzgerald
2013-02-19 17:24 ` Richard Fitzgerald
2013-02-20 5:50 ` Vinod Koul
2013-02-22 15:56 ` [PATCH TINYCOMPRESS 1/14 v2] " Richard Fitzgerald
2013-02-22 18:09 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5118FBF8.9060804@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=rf@opensource.wolfsonmicro.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).