From: Mike Looijmans <mike.looijmans@topic.nl>
To: Michal Bachraty <michal.bachraty@streamunlimited.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: davici-mcasp: "tx-num-evt" confusion with number of serializers
Date: Thu, 28 Feb 2013 10:32:15 +0100 [thread overview]
Message-ID: <512F241F.9080305@topic.nl> (raw)
In-Reply-To: <8652573.mejjkM8Cr8@ganymedes>
On 02/28/2013 10:06 AM, Michal Bachraty wrote:
> Hi Mike,
>
> Many thanks!
> Now all about "tx-num-evt" or "rx-num-evt" make sense.
>
>> Maybe the misleading "rx_num_evt" should be renamed to "use_rx_fifo". I
>> understand that not all McASP interfaces have a FIFO
>
> Maybe, "rx_fifo_depth" could be also used.
That's a big improvement over "rx_num_evt". The first time I saw this
struct, I thought I had to set rx_num_evt to the number of receiving AXR
pins in use.
Maybe call it "rx_min_fifo_depth" because just "depth" might be
interpreted as the capaciity or maximum size of the fifo, while in fact
the parameter is a minimum amount of data to be put into the FIFO
buffer. Of maybe "rx_fifo_thd" to indicate it's a threshhold. And use
the same name for the "tx" part as well (tx_fifo_thd or tx_fifo_min_depth).
Mike.
next prev parent reply other threads:[~2013-02-28 9:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-26 14:06 davici-mcasp: "tx-num-evt" confusion with number of serializers Michal Bachraty
2013-02-26 18:40 ` Mike Looijmans
2013-02-27 11:36 ` Michal Bachraty
2013-02-27 12:05 ` Mike Looijmans
2013-02-28 9:06 ` Michal Bachraty
2013-02-28 9:32 ` Mike Looijmans [this message]
2013-02-28 11:02 ` Michal Bachraty
2013-02-28 13:19 ` Daniel Mack
2013-02-28 13:26 ` Daniel Mack
2013-03-01 10:08 ` Mark Brown
2013-03-06 10:51 ` Bedia, Vaibhav
2013-03-08 16:11 ` Michal Bachraty
2013-03-11 7:09 ` Bedia, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512F241F.9080305@topic.nl \
--to=mike.looijmans@topic.nl \
--cc=alsa-devel@alsa-project.org \
--cc=michal.bachraty@streamunlimited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).