From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gabriele Mazzotta Subject: Re: [PATCH] ALSA: hda - Disable AA-loopback on ALC668 Date: Thu, 15 May 2014 21:56:23 +0200 Message-ID: <5132959.uTC67tbQhF@xps13> References: <1784940.JdFq8Pv96a@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f66.google.com (mail-ee0-f66.google.com [74.125.83.66]) by alsa0.perex.cz (Postfix) with ESMTP id 47FDE2625D7 for ; Thu, 15 May 2014 21:56:26 +0200 (CEST) Received: by mail-ee0-f66.google.com with SMTP id e53so734199eek.1 for ; Thu, 15 May 2014 12:56:26 -0700 (PDT) Received: from xps13.localnet ([193.190.253.149]) by mx.google.com with ESMTPSA id x45sm14830773eeu.23.2014.05.15.12.56.24 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 May 2014 12:56:25 -0700 (PDT) In-Reply-To: <1784940.JdFq8Pv96a@xps13> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Wednesday 14 May 2014 16:31:13, Gabriele Mazzotta wrote: > Disable the AA-loopback path to get rid of the constant white noise > that can be heard when headphones are used. > > This patch was tested only on a Dell XPS13 9333. > > Fix based on d2e92709e88d ("ALSA: hda - Disable AA-loopback on ALC283 > Chromebook"). > > Signed-off-by: Gabriele Mazzotta > --- > sound/pci/hda/patch_realtek.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 5f7c765..21c94e4 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5690,6 +5690,13 @@ static int patch_alc662(struct hda_codec *codec) > if (has_cdefine_beep(codec)) > spec->gen.beep_nid = 0x01; > > + switch (codec->vendor_id) { > + case 0x10ec0668: > + /* Disable AA-loopback as it causes white noise */ > + spec->gen.mixer_nid = 0; > + break; > + } > + > if ((alc_get_coef0(codec) & (1 << 14)) && > codec->bus->pci && codec->bus->pci->subsystem_vendor == 0x1025 && > spec->cdefine.platform_type == 1) { > I'm sorry, I was wrong. This patch does not help. I'm still trying to understand what temporarily fixed the problem, I was quite sure this patch did it, but all of the sudden the noise came back. I'm still trying to find the real cause, but I doubt I'll succeed. Regards, Gabriele