From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: "Sebastien Guiriec" <s-guiriec@ti.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@opensource.wolfsonmicro.com>,
"Benoît Cousson" <b-cousson@ti.com>,
"Tony Lindgren" <tony@atomide.com>,
linux-omap@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 0/5] ASoC: OMAP2+: Update Audio IP with sDMA binding for DT boot
Date: Fri, 8 Mar 2013 10:23:41 +0100 [thread overview]
Message-ID: <5139AE1D.3080102@ti.com> (raw)
In-Reply-To: <20130308092543.c355b2c6235c297efbe162e0@bitmer.com>
On 03/08/2013 08:25 AM, Jarkko Nikula wrote:
>> The content of the patches looks about right for me, however I would
>> squash together the IP and platform driver patches so we avoid breakage
>> within the series. Also I would put the patch for the .dtsi files as
>> first one.
>>
> Looks ok to me too at quick look. Would it be possible to avoid possible
> breakage if first patch is divided to omap-pcm.h change which come before
> audio link driver changes and do omap-pcm.c change last?
If we have them as separate we will have runtime regression between the
patches. It is better to have them squashed together.
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-03-08 9:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 12:43 [PATCH 0/5] ASoC: OMAP2+: Update Audio IP with sDMA binding for DT boot Sebastien Guiriec
2013-03-07 12:43 ` [PATCH 1/5] ASoC: omap-pcm: Move to generic DMA for DT binding Sebastien Guiriec
2013-03-07 12:43 ` [PATCH 2/5] ASoC: omap-dmic: Update driver for DMA " Sebastien Guiriec
2013-03-07 12:43 ` [PATCH 3/5] ASoC: omap-mcpdm: " Sebastien Guiriec
2013-03-07 12:43 ` [PATCH 4/5] ASoC: omap-mcbsp:Update " Sebastien Guiriec
2013-03-07 12:43 ` [PATCH 5/5] ARM: dts: OMAP2+: Add SDMA Audio IPs bindings Sebastien Guiriec
2013-03-07 13:03 ` [PATCH 0/5] ASoC: OMAP2+: Update Audio IP with sDMA binding for DT boot Peter Ujfalusi
2013-03-08 7:25 ` Jarkko Nikula
2013-03-08 9:23 ` Peter Ujfalusi [this message]
2013-03-08 17:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5139AE1D.3080102@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=b-cousson@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jarkko.nikula@bitmer.com \
--cc=lgirdwood@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=s-guiriec@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).