From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: [PATCH] ALSA: ASoC: davinci-mcasp: clean ip davinci_hw_common_param() Date: Mon, 11 Mar 2013 09:49:27 +0100 Message-ID: <513D9A97.7030901@gmail.com> References: <1362748778-11076-1-git-send-email-zonque@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by alsa0.perex.cz (Postfix) with ESMTP id 3EA8326030A for ; Mon, 11 Mar 2013 09:49:30 +0100 (CET) Received: by mail-bk0-f54.google.com with SMTP id w5so1547803bku.41 for ; Mon, 11 Mar 2013 01:49:29 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Bedia, Vaibhav" Cc: "alsa-devel@alsa-project.org" , "broonie@opensource.wolfsonmicro.com" , Michal Bachraty List-Id: alsa-devel@alsa-project.org On 11.03.2013 08:09, Bedia, Vaibhav wrote: > On Fri, Mar 08, 2013 at 18:49:38, Daniel Mack wrote: >> As pointed of by Vaibhav, commit 2952b27e2 ("ASoC: davinci-mcasp: >> Add support for multichannel playback") duplicated the logic of >> counting the active serializers. That can be avoided by shifting >> the code around a bit. >> >> Also, drop two unused defines introduced by the same commit. >> > > s/clean ip/clean up/ in the $subject. > > Other than that, this looks fine to me. > > Acked-by: Vaibhav Bedia > Thanks! Mark - you want me to resend with the fixed subject line or can you do it when commiting? Daniel