From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Sebastien Guiriec <s-guiriec@ti.com>
Cc: alsa-devel@alsa-project.org, "Benoît Cousson" <b-cousson@ti.com>,
"Tony Lindgren" <tony@atomide.com>,
"Mark Brown" <broonie@opensource.wolfsonmicro.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-omap@vger.kernel.org,
"Jarkko Nikula" <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH V2 1/2] ARM: dts: OMAP2+: Add SDMA Audio IPs bindings
Date: Mon, 11 Mar 2013 15:19:22 +0100 [thread overview]
Message-ID: <513DE7EA.4080805@ti.com> (raw)
In-Reply-To: <1362988223-22455-2-git-send-email-s-guiriec@ti.com>
On 03/11/2013 08:50 AM, Sebastien Guiriec wrote:
> Populate DMA client information for McBSP DMIC and McPDM periperhal on
> OMAP2+ devices.
Looks good to me:
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Signed-off-by: Sebastien Guiriec <s-guiriec@ti.com>
> ---
> arch/arm/boot/dts/omap2420.dtsi | 6 ++++++
> arch/arm/boot/dts/omap2430.dtsi | 15 +++++++++++++++
> arch/arm/boot/dts/omap3.dtsi | 15 +++++++++++++++
> arch/arm/boot/dts/omap4.dtsi | 17 +++++++++++++++++
> arch/arm/boot/dts/omap5.dtsi | 14 ++++++++++++++
> 5 files changed, 67 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap2420.dtsi b/arch/arm/boot/dts/omap2420.dtsi
> index af65609..45930f2 100644
> --- a/arch/arm/boot/dts/omap2420.dtsi
> +++ b/arch/arm/boot/dts/omap2420.dtsi
> @@ -37,6 +37,9 @@
> <60>; /* RX interrupt */
> interrupt-names = "tx", "rx";
> ti,hwmods = "mcbsp1";
> + dmas = <&sdma 31>,
> + <&sdma 32>;
> + dma-names = "tx", "rx";
> };
>
> mcbsp2: mcbsp@48076000 {
> @@ -47,6 +50,9 @@
> <63>; /* RX interrupt */
> interrupt-names = "tx", "rx";
> ti,hwmods = "mcbsp2";
> + dmas = <&sdma 33>,
> + <&sdma 34>;
> + dma-names = "tx", "rx";
> };
>
> timer1: timer@48028000 {
> diff --git a/arch/arm/boot/dts/omap2430.dtsi b/arch/arm/boot/dts/omap2430.dtsi
> index c392445..cfe7ed9 100644
> --- a/arch/arm/boot/dts/omap2430.dtsi
> +++ b/arch/arm/boot/dts/omap2430.dtsi
> @@ -40,6 +40,9 @@
> interrupt-names = "common", "tx", "rx", "rx_overflow";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp1";
> + dmas = <&sdma 31>,
> + <&sdma 32>;
> + dma-names = "tx", "rx";
> };
>
> mcbsp2: mcbsp@48076000 {
> @@ -52,6 +55,9 @@
> interrupt-names = "common", "tx", "rx";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp2";
> + dmas = <&sdma 33>,
> + <&sdma 34>;
> + dma-names = "tx", "rx";
> };
>
> mcbsp3: mcbsp@4808c000 {
> @@ -64,6 +70,9 @@
> interrupt-names = "common", "tx", "rx";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp3";
> + dmas = <&sdma 17>,
> + <&sdma 18>;
> + dma-names = "tx", "rx";
> };
>
> mcbsp4: mcbsp@4808e000 {
> @@ -76,6 +85,9 @@
> interrupt-names = "common", "tx", "rx";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp4";
> + dmas = <&sdma 19>,
> + <&sdma 20>;
> + dma-names = "tx", "rx";
> };
>
> mcbsp5: mcbsp@48096000 {
> @@ -88,6 +100,9 @@
> interrupt-names = "common", "tx", "rx";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp5";
> + dmas = <&sdma 21>,
> + <&sdma 22>;
> + dma-names = "tx", "rx";
> };
>
> timer1: timer@49018000 {
> diff --git a/arch/arm/boot/dts/omap3.dtsi b/arch/arm/boot/dts/omap3.dtsi
> index 4e7acb6..f901404 100644
> --- a/arch/arm/boot/dts/omap3.dtsi
> +++ b/arch/arm/boot/dts/omap3.dtsi
> @@ -289,6 +289,9 @@
> interrupt-names = "common", "tx", "rx";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp1";
> + dmas = <&sdma 31>,
> + <&sdma 32>;
> + dma-names = "tx", "rx";
> };
>
> mcbsp2: mcbsp@49022000 {
> @@ -303,6 +306,9 @@
> interrupt-names = "common", "tx", "rx", "sidetone";
> ti,buffer-size = <1280>;
> ti,hwmods = "mcbsp2", "mcbsp2_sidetone";
> + dmas = <&sdma 33>,
> + <&sdma 34>;
> + dma-names = "tx", "rx";
> };
>
> mcbsp3: mcbsp@49024000 {
> @@ -317,6 +323,9 @@
> interrupt-names = "common", "tx", "rx", "sidetone";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp3", "mcbsp3_sidetone";
> + dmas = <&sdma 17>,
> + <&sdma 18>;
> + dma-names = "tx", "rx";
> };
>
> mcbsp4: mcbsp@49026000 {
> @@ -329,6 +338,9 @@
> interrupt-names = "common", "tx", "rx";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp4";
> + dmas = <&sdma 19>,
> + <&sdma 20>;
> + dma-names = "tx", "rx";
> };
>
> mcbsp5: mcbsp@48096000 {
> @@ -341,6 +353,9 @@
> interrupt-names = "common", "tx", "rx";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp5";
> + dmas = <&sdma 21>,
> + <&sdma 22>;
> + dma-names = "tx", "rx";
> };
>
> timer1: timer@48318000 {
> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
> index 827f6f3..413c683 100644
> --- a/arch/arm/boot/dts/omap4.dtsi
> +++ b/arch/arm/boot/dts/omap4.dtsi
> @@ -388,6 +388,9 @@
> reg-names = "mpu", "dma";
> interrupts = <0 112 0x4>;
> ti,hwmods = "mcpdm";
> + dmas = <&sdma 65>,
> + <&sdma 66>;
> + dma-names = "up_link", "dn_link";
> };
>
> dmic: dmic@4012e000 {
> @@ -397,6 +400,8 @@
> reg-names = "mpu", "dma";
> interrupts = <0 114 0x4>;
> ti,hwmods = "dmic";
> + dmas = <&sdma 67>;
> + dma-names = "up_link";
> };
>
> mcbsp1: mcbsp@40122000 {
> @@ -408,6 +413,9 @@
> interrupt-names = "common";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp1";
> + dmas = <&sdma 33>,
> + <&sdma 34>;
> + dma-names = "tx", "rx";
> };
>
> mcbsp2: mcbsp@40124000 {
> @@ -419,6 +427,9 @@
> interrupt-names = "common";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp2";
> + dmas = <&sdma 17>,
> + <&sdma 18>;
> + dma-names = "tx", "rx";
> };
>
> mcbsp3: mcbsp@40126000 {
> @@ -430,6 +441,9 @@
> interrupt-names = "common";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp3";
> + dmas = <&sdma 19>,
> + <&sdma 20>;
> + dma-names = "tx", "rx";
> };
>
> mcbsp4: mcbsp@48096000 {
> @@ -440,6 +454,9 @@
> interrupt-names = "common";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp4";
> + dmas = <&sdma 31>,
> + <&sdma 32>;
> + dma-names = "tx", "rx";
> };
>
> keypad: keypad@4a31c000 {
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index 39b8d76..5aa6086 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -364,6 +364,9 @@
> reg-names = "mpu", "dma";
> interrupts = <0 112 0x4>;
> ti,hwmods = "mcpdm";
> + dmas = <&sdma 65>,
> + <&sdma 66>;
> + dma-names = "up_link", "dn_link";
> };
>
> dmic: dmic@4012e000 {
> @@ -373,6 +376,8 @@
> reg-names = "mpu", "dma";
> interrupts = <0 114 0x4>;
> ti,hwmods = "dmic";
> + dmas = <&sdma 67>;
> + dma-names = "up_link";
> };
>
> mcbsp1: mcbsp@40122000 {
> @@ -384,6 +389,9 @@
> interrupt-names = "common";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp1";
> + dmas = <&sdma 33>,
> + <&sdma 34>;
> + dma-names = "tx", "rx";
> };
>
> mcbsp2: mcbsp@40124000 {
> @@ -395,6 +403,9 @@
> interrupt-names = "common";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp2";
> + dmas = <&sdma 17>,
> + <&sdma 18>;
> + dma-names = "tx", "rx";
> };
>
> mcbsp3: mcbsp@40126000 {
> @@ -406,6 +417,9 @@
> interrupt-names = "common";
> ti,buffer-size = <128>;
> ti,hwmods = "mcbsp3";
> + dmas = <&sdma 19>,
> + <&sdma 20>;
> + dma-names = "tx", "rx";
> };
>
> timer1: timer@4ae18000 {
>
--
Péter
next prev parent reply other threads:[~2013-03-11 14:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 7:50 [PATCH V2 0/2] ASoC: OMAP2+: Update Audio IP with sDMA binding for DT boot Sebastien Guiriec
2013-03-11 7:50 ` [PATCH V2 1/2] ARM: dts: OMAP2+: Add SDMA Audio IPs bindings Sebastien Guiriec
2013-03-11 14:19 ` Peter Ujfalusi [this message]
2013-03-11 18:29 ` Jarkko Nikula
2013-03-11 7:50 ` [PATCH V2 2/2] ASoC: OMAP2+: Move McBSP, DMIC and McPDM to generic DMA DT binding Sebastien Guiriec
2013-03-11 14:18 ` Peter Ujfalusi
2013-03-11 18:29 ` Jarkko Nikula
2013-03-11 14:33 ` Mark Brown
2013-03-11 16:27 ` Tony Lindgren
2013-03-11 16:28 ` Mark Brown
2013-03-11 16:38 ` Tony Lindgren
2013-03-12 18:26 ` Mark Brown
2013-03-13 10:36 ` Mark Brown
2013-03-15 14:27 ` [PATCH V2 0/2] ASoC: OMAP2+: Update Audio IP with sDMA binding for DT boot Benoit Cousson
2013-03-15 16:56 ` Mark Brown
2013-03-15 17:01 ` Benoit Cousson
2013-03-15 17:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513DE7EA.4080805@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=b-cousson@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jarkko.nikula@bitmer.com \
--cc=lgirdwood@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=s-guiriec@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).