From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: [PATCH -next] ASoC: tas5086: use module_i2c_driver to simplify the code Date: Tue, 12 Mar 2013 14:40:29 +0100 Message-ID: <513F304D.4090405@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Wei Yongjun Cc: lgirdwood@gmail.com, broonie@opensource.wolfsonmicro.com, perex@perex.cz, tiwai@suse.de, grant.likely@secretlab.ca, rob.herring@calxeda.com, yongjun_wei@trendmicro.com.cn, alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On 12.03.2013 14:36, Wei Yongjun wrote: > From: Wei Yongjun > > Use the module_i2c_driver() macro to make the code smaller > and a bit simpler. Thanks for catching this! > Signed-off-by: Wei Yongjun Acked-by: Daniel Mack > --- > sound/soc/codecs/tas5086.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/sound/soc/codecs/tas5086.c b/sound/soc/codecs/tas5086.c > index 008bea4..40cee84 100644 > --- a/sound/soc/codecs/tas5086.c > +++ b/sound/soc/codecs/tas5086.c > @@ -584,17 +584,7 @@ static struct i2c_driver tas5086_i2c_driver = { > .remove = tas5086_i2c_remove, > }; > > -static int __init tas5086_modinit(void) > -{ > - return i2c_add_driver(&tas5086_i2c_driver); > -} > -module_init(tas5086_modinit); > - > -static void __exit tas5086_modexit(void) > -{ > - i2c_del_driver(&tas5086_i2c_driver); > -} > -module_exit(tas5086_modexit); > +module_i2c_driver(tas5086_i2c_driver); > > MODULE_AUTHOR("Daniel Mack "); > MODULE_DESCRIPTION("Texas Instruments TAS5086 ALSA SoC Codec Driver"); > >