From: Lars-Peter Clausen <lars@metafoo.de>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Simon <horms@verge.net.au>,
Liam Girdwood <liam.r.girdwood@intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH 1/2 v2] ASoC: add snd_soc_register_component()
Date: Tue, 12 Mar 2013 19:57:47 +0100 [thread overview]
Message-ID: <513F7AAB.8040401@metafoo.de> (raw)
In-Reply-To: <513F71BF.3040608@wwwdotorg.org>
On 03/12/2013 07:19 PM, Stephen Warren wrote:
> On 03/11/2013 07:27 PM, Kuninori Morimoto wrote:
>> Current ASoC has register function for platform/codec/dai/card,
>> but doesn't have for cpu.
>> It often produces confusion and fault on ASoC.
>>
>> As result of ASoC community discussion,
>> we consider new struct snd_soc_component for CPU/CODEC,
>> and will switch over to use it.
>>
>> This patch adds very basic struct snd_soc_component,
>> and register function for it.
>
> The series seems reasonable enough to me, as a basis for future work on
> the DT stuff, so,
>
> Reviewed-by: Stephen Warren <swarren@nvidia.com>
>
> I wonder how much work it is to convert all users of
> snd_soc_register_dais() to this new API; is it worth doing so?
If we allow the component driver to be NULL it's pretty much straight
forward using coccinelle. Don't know if it is worth it to conver them all
right away.
@@
expression dev;
@@
-snd_soc_register_dais(
+snd_soc_register_component(
dev,
+NULL,
...)
@@
expression dev;
expression num_dais;
@@
-snd_soc_unregister_dais(
+snd_soc_unregister_component(
dev,
-num_dais
)
- Lars
next prev parent reply other threads:[~2013-03-12 18:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 1:49 [PATCH 0/2] ASoC: add new struct snd_soc_chip Kuninori Morimoto
2013-03-08 1:50 ` [PATCH 1/2] ASoC: add snd_soc_register_chip() Kuninori Morimoto, Kuninori Morimoto
2013-03-08 20:53 ` Stephen Warren
2013-03-08 1:53 ` [PATCH 2/2] ASoC: fsi: use snd_soc_register_chip() instead of snd_soc_register_dais() Kuninori Morimoto, Kuninori Morimoto
2013-03-12 1:26 ` [PATCH 0/2 v2] ASoC: add new struct snd_soc_component Kuninori Morimoto
2013-03-12 1:27 ` [PATCH 1/2 v2] ASoC: add snd_soc_register_component() Kuninori Morimoto
2013-03-12 18:19 ` Stephen Warren
2013-03-12 18:57 ` Lars-Peter Clausen [this message]
2013-03-12 19:40 ` Mark Brown
2013-03-12 21:35 ` Stephen Warren
2013-03-13 10:13 ` Mark Brown
2013-03-13 11:08 ` Mark Brown
2013-03-12 1:27 ` [PATCH 2/2 v2] ASoC: fsi: use snd_soc_register_component() instead of snd_soc_register_dais() Kuninori Morimoto
2013-03-12 20:02 ` Mark Brown
2013-03-13 0:38 ` Kuninori Morimoto
2013-03-13 10:14 ` Mark Brown
2013-03-14 7:18 ` [PATCH 1/2] ASoC: add .name for snd_soc_component_driver Kuninori Morimoto
2013-03-15 1:25 ` Mark Brown
2013-03-14 7:19 ` [PATCH 2/2] ASoC: fsi: use snd_soc_register_component() instead of snd_soc_register_dais() Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513F7AAB.8040401@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@intel.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).