Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ola Lilja <ola.o.lilja@stericsson.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 01/14] ASoC: ux500_pcm: Remove duplicated SNDRV_PCM_HW_PARAM_PERIODS constraint
Date: Fri, 22 Mar 2013 15:35:37 +0100	[thread overview]
Message-ID: <514C6C39.5000806@stericsson.com> (raw)
In-Reply-To: <1363957934-20059-2-git-send-email-lars@metafoo.de>

Acked.

Regards,
Ola

On 03/22/2013 02:12 PM, Lars-Peter Clausen wrote:

> The generic dmaengine based PCM driver code takes care of setting this
> constraint, there is no need of doing it manually in the ux500 driver.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Ola Lilja <ola.o.lilja@stericsson.com>
> ---
>  sound/soc/ux500/ux500_pcm.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/sound/soc/ux500/ux500_pcm.c b/sound/soc/ux500/ux500_pcm.c
> index 846fa82..375ca6b 100644
> --- a/sound/soc/ux500/ux500_pcm.c
> +++ b/sound/soc/ux500/ux500_pcm.c
> @@ -111,15 +111,6 @@ static int ux500_pcm_open(struct snd_pcm_substream *substream)
>  		snd_soc_set_runtime_hwparams(substream,
>  					&ux500_pcm_hw_capture);
>  
> -	/* ensure that buffer size is a multiple of period size */
> -	ret = snd_pcm_hw_constraint_integer(runtime,
> -					SNDRV_PCM_HW_PARAM_PERIODS);
> -	if (ret < 0) {
> -		dev_err(dev, "%s: Error: snd_pcm_hw_constraints failed (%d)\n",
> -			__func__, ret);
> -		return ret;
> -	}
> -
>  	dev_dbg(dev, "%s: Set hw-struct for %s.\n", __func__,
>  		snd_pcm_stream_str(substream));
>  	runtime->hw = (stream_id == SNDRV_PCM_STREAM_PLAYBACK) ?

  reply	other threads:[~2013-03-22 14:36 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-22 13:12 [PATCH 00/14] ASoC: Cleanup dmaengine PCM users Lars-Peter Clausen
2013-03-22 13:12 ` [PATCH 01/14] ASoC: ux500_pcm: Remove duplicated SNDRV_PCM_HW_PARAM_PERIODS constraint Lars-Peter Clausen
2013-03-22 14:35   ` Ola Lilja [this message]
2013-03-22 13:12 ` [PATCH 02/14] ASoC: spear_pcm: No need to wrap snd_dmaengine_pcm_close() Lars-Peter Clausen
2013-03-25  3:51   ` Rajeev kumar
2013-03-22 13:12 ` [PATCH 03/14] ASoC: omap-pcm: " Lars-Peter Clausen
2013-03-22 13:13   ` Peter Ujfalusi
2013-03-22 14:15     ` Jarkko Nikula
2013-03-22 13:12 ` [PATCH 04/14] ASoC: tegra_pcm: " Lars-Peter Clausen
2013-03-22 15:44   ` Stephen Warren
2013-03-22 13:12 ` [PATCH 05/14] ASoC: ux500_pcm: " Lars-Peter Clausen
2013-03-22 14:36   ` Ola Lilja
2013-03-22 13:12 ` [PATCH 06/14] ASoC: atmel-pcm-dma: " Lars-Peter Clausen
2013-03-25  8:37   ` Bo Shen
2013-03-22 13:12 ` [PATCH 07/14] ASoC: ux500_pcm: No need to use snd_dmaengine_pcm_set_data() Lars-Peter Clausen
2013-03-22 15:01   ` Ola Lilja
2013-03-26 14:16     ` Mark Brown
2013-03-22 13:12 ` [PATCH 08/14] ASoC: speaer_pcm: " Lars-Peter Clausen
2013-03-25  3:59   ` Rajeev kumar
2013-03-25  8:22     ` Lars-Peter Clausen
2013-03-25  8:36       ` Rajeev kumar
2013-03-22 13:12 ` [PATCH 09/14] ASoC: atmel-pcm-dma: Do not use snd_dmaengine_pcm_{set, get}_data() Lars-Peter Clausen
2013-03-25  8:39   ` Bo Shen
2013-03-22 13:12 ` [PATCH 10/14] ASoC: ep93xx: Use ep93xx_dma_params instead of ep93xx_pcm_dma_params Lars-Peter Clausen
2013-03-22 13:12 ` [PATCH 11/14] ASoC: mmp-pcm: Allocate dma filter parameters on the stack Lars-Peter Clausen
2013-03-22 13:12 ` [PATCH 12/14] ASoC: imx-pcm: Embed the imx_dma_data struct in the dma_params struct Lars-Peter Clausen
2013-03-25  2:33   ` Shawn Guo
2013-03-22 13:12 ` [PATCH 13/14] ASoC: mxs: Embed the mxs_dma_data struct in the mxs_pcm_dma_params struct Lars-Peter Clausen
2013-03-25  2:04   ` Shawn Guo
2013-03-22 13:12 ` [PATCH 14/14] ASoC: dmaengine-pcm: Remove snd_dmaengine_pcm_{set, get}_data Lars-Peter Clausen
2013-03-26 14:18 ` [PATCH 00/14] ASoC: Cleanup dmaengine PCM users Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514C6C39.5000806@stericsson.com \
    --to=ola.o.lilja@stericsson.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox