From: Stephen Warren <swarren@wwwdotorg.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: ASoC: tegra: Does the PCM_TRIGGER_{PAUSE, RESUME} emulation really work?
Date: Fri, 22 Mar 2013 17:35:01 -0600 [thread overview]
Message-ID: <514CEAA5.4040505@wwwdotorg.org> (raw)
In-Reply-To: <514C8618.9070307@metafoo.de>
On 03/22/2013 10:26 AM, Lars-Peter Clausen wrote:
> Hi,
>
> The tegra pcm driver tries to emulate SNDRV_PCM_TRIGGER_PAUSE and
> SNDRV_PCM_TRIGGER_RESUME. By passing SNDRV_PCM_TRIGGER_START and
> SNDRV_PCM_TRIGGER_STOP to snd_dmaengine_pcm_trigger. But does this really
> work? The old non-dmaengine based driver implemented this properly. I'd
> reset the dma position pointer for SNDRV_PCM_TRIGGER_START, but keep it
> where it was for SNDRV_PCM_TRIGGER_RESUME. But as far as I can see with the
> dmaengine based driver the pointer always gets reset to 0 for both
> SNDRV_PCM_TRIGGER_START and SNDRV_PCM_TRIGGER_RESUME.
It's quite possible this hasn't been tested, or tested recently. I don't
recall how to test PAUSE/RESUME. Can you enlighten me?
Laxman, can you comment here?
next prev parent reply other threads:[~2013-03-22 23:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 16:26 ASoC: tegra: Does the PCM_TRIGGER_{PAUSE, RESUME} emulation really work? Lars-Peter Clausen
2013-03-22 23:35 ` Stephen Warren [this message]
2013-03-23 10:00 ` Lars-Peter Clausen
[not found] ` <514DAB42.6090601@nvidia.com>
2013-03-23 13:29 ` Lars-Peter Clausen
[not found] ` <514DADE9.50402@nvidia.com>
2013-03-23 13:36 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514CEAA5.4040505@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=ldewangan@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox