From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17A24C433DB for ; Tue, 2 Feb 2021 16:25:41 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C75F964F7A for ; Tue, 2 Feb 2021 16:25:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C75F964F7A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B7027171E; Tue, 2 Feb 2021 17:24:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B7027171E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612283137; bh=lxASZWMgZnpkAJCzgt9ZNixhNDP2St8/5DUFh0LYTR4=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=cAAlSEWPoSsj7NDZdxp/QyJQe2wpZuhJyIJnKtJYzYR6HUlAKmslDPK6GoYpdLD1N V6KUbwj2nDDJJw5Wn78GPjy86Q0e38BAGF7FOP1OhZh5tYhrp4zzYzqEjp0Hj5oIos /S2+F8pKWznycGIkTKNnCKIalZSPthmkR8oIbfwM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2FEF0F80152; Tue, 2 Feb 2021 17:24:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9D307F80171; Tue, 2 Feb 2021 17:24:45 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0FF42F8013C for ; Tue, 2 Feb 2021 17:24:39 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0FF42F8013C Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="OLaOgypb" Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 02 Feb 2021 08:24:36 -0800 Received: from [10.26.73.224] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 2 Feb 2021 16:24:33 +0000 Subject: Re: [PATCH v1 2/2] ASoC: tegra: Add RT5631 machine driver To: Dmitry Osipenko , Ion Agorria , Thierry Reding , Stephen Warren , Liam Girdwood , Mark Brown , Takashi Iwai , Jaroslav Kysela , Rob Herring , Svyatoslav Ryhel , Ion Agorria References: <20210131184101.651486-1-AG0RRIA@yahoo.com> <20210131184101.651486-3-AG0RRIA@yahoo.com> <7f4eb8f7-215e-ab3d-fcef-9243037cf246@nvidia.com> <8d0bc6f3-45ce-565d-d80f-b50fb75e7c55@gmail.com> From: Jon Hunter Message-ID: <51571ec9-780b-ba71-c81d-dd01ebcefbb8@nvidia.com> Date: Tue, 2 Feb 2021 16:24:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <8d0bc6f3-45ce-565d-d80f-b50fb75e7c55@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612283076; bh=CEvP7Tc+GVpLUt9/g/q0cu5A7O0MJxg4tJPKJVFK2TQ=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=OLaOgypbOgXoCBypRvB4lzmBlljAml6HE+jwwCRJX3TpY3GR038XVJWyZrS0ATVF5 SkXKFACbfjJw1DeMcyOjyEi2wK8K48xdoZcCu5wZqINh9SVuZJyk0VZC/M7oHGaPpH 2kYNT4GjZD+dSOQqkOyYtHFFK4MFE0KuiwrJYN78TQqB7EEDhoxiSzho56n3wg/ldP c6bSbihD/jQxTDQOVmya28qE0323C5va6znTIpCA5TDljVwqRKCRjed2QqPex1XgH8 aPKF/xhBdIal6CcqwRXndKmr+7nHf9FJami2Su/w7oCbn6xv5CGoPL7e7AbMHTWzgv 4Tt0L3l4OGhbw== Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 02/02/2021 15:25, Dmitry Osipenko wrote: > 02.02.2021 16:22, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> So this is very similar to tegra_rt5677, is it not possible to support >> both codecs with the same machine driver? >=20 > These codecs require individual configurations and those > "../codecs/rt5631.h" and "../codecs/rt5677.h" aren't compatible at a > quick glance. Right but not all of that is needed. What is actually needed from the header files? > The tegra_rt5677 also uses outdated GPIO API and etc. Hence the new > driver should be a better base anyways. Sounds like a good time to update it :-) > Overall it shouldn't worth time and effort trying to squeeze these > drivers into a single one, IMO. Not sure I agree when these drivers appear to be 90% the same. Jon --=20 nvpublic