12.04.2013 19:24, Gabriel M. Beddingfield пишет:
> On 04/12/2013 08:20 AM, Stas Sergeev wrote:
>>> He means that the commit message. Your commit message says what the
>>> patch does. It does not say why the patch is needed.
>> Yes.
>> But what should I add to the commit message, if the
>> only thing I know about this patch, is that I am not getting
>> any sound without it? :) The reason should be obvious for
>> whoever is familiar with that subsystem, but its not me.
>>
>
> Yep, just formalize the "I am not getting any sound with it"
> statement. :-)
Hi, Would something like the attached patch be good to
help formalizing this? With that patch I am getting:
---
[    2.800190] asoc: no playback or capture streams
available                  
[    2.805158] asoc: can't create pcm
Pri_Dai                                  
[    2.809241] asoc: failed to instantiate card I2S: -22
---
which is much better than before.
If I get any ACKs on this one, I'll submit it too.