Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: alsa-devel@alsa-project.org
Cc: tova-dev@tovacompany.com, linux-usb@vger.kernel.org,
	Joe Rayhawk <jrayhawk@fairlystable.org>,
	alsa-devel@vger.kernel.org
Subject: Re: [alsa-devel] BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP'
Date: Tue, 23 Apr 2013 10:47:44 +0200	[thread overview]
Message-ID: <51764AB0.7020301@ladisch.de> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1304221126200.1388-100000@iolanthe.rowland.org>

Alan Stern wrote:
> On Fri, 19 Apr 2013, Joe Rayhawk wrote:
>> On Fri, Apr 19, 2013 at 02:18:24PM -0400, Alan Stern wrote:
>>> On Fri, 19 Apr 2013, Clemens Ladisch wrote:
>>>> Alan Stern wrote:
>>>>> +		next = uhci->frame_number + 2;
>>>>>
>>>>> That 2 is the minimum latency, in frames (one frame per ms).
>>>>
>>>> One frame worked fine with the old driver.  What is the reason for
>>>> this regression?
>>>
>>> Perhaps that was a mistake.  Joe, you can try changing the 2 above to a
>>> 1 to see if it fixes the problem.
>>
>> Hey, that worked great! Audio's coming through continuously, now.
>
> This change could be added to the driver, but I would prefer not to.

Why do you think it is necessary to have a minimum latency of 2 ms?

Again, the old algorithm worked fine.  While such short queues are not
used by default, they are necessary to get low latencies for real-time
audio applications.  Keeping this change would keep this regression for
quite a few people.

> In any case, it would be best

What criteria are you using to evaluate the benefit of this?  Do you
want to reduce the chance of queue underruns?  Interrupts?  Power usage?

> if the usb-audio driver were changed to keep the pipeline length at
> least 2 ms at all times.

Why is having a queue of two URB with one packet each suddenly not
allowed?


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe alsa-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2013-04-23  8:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20130417183436.GA4381@richardiv.omgwallhack.org>
2013-04-18 16:42 ` [alsa-devel] BUG: USB audio discontinuities with 'UHCI: implement new semantics for URB_ISO_ASAP' Alan Stern
2013-04-18 21:23   ` Joe Rayhawk
2013-04-18 21:23   ` [alsa-devel] " Joe Rayhawk
2013-04-19 15:57     ` Alan Stern
2013-04-19 16:25       ` Clemens Ladisch
2013-04-19 16:25       ` [alsa-devel] " Clemens Ladisch
2013-04-19 18:18         ` Alan Stern
2013-04-19 18:18         ` [alsa-devel] " Alan Stern
2013-04-20  0:35           ` Joe Rayhawk
2013-04-22 15:29             ` Alan Stern
2013-04-23  8:47               ` Clemens Ladisch
2013-04-23  8:47               ` Clemens Ladisch [this message]
2013-04-23 14:58                 ` Alan Stern
2013-04-23 14:58                 ` [alsa-devel] " Alan Stern
2013-04-23 15:09                   ` Clemens Ladisch
2013-04-23 15:23                     ` Alan Stern
2013-04-23 15:23                     ` [alsa-devel] " Alan Stern
2013-04-23 15:09                   ` Clemens Ladisch
2013-04-22 15:29             ` Alan Stern
2013-04-20  0:35           ` Joe Rayhawk
2013-04-19 15:57     ` Alan Stern
2013-04-18 16:42 ` Alan Stern
     [not found] <20130509001613.GA4383@richardiv.omgwallhack.org>
2013-05-09 14:38 ` [alsa-devel] " Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51764AB0.7020301@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=alsa-devel@vger.kernel.org \
    --cc=jrayhawk@fairlystable.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tova-dev@tovacompany.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox