From: Lars-Peter Clausen <lars@metafoo.de>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, broonie@kernel.org,
patches@linaro.org
Subject: Re: [PATCH 6/6] ASoC: jz4740: Remove redundant platform_set_drvdata()
Date: Fri, 03 May 2013 11:24:37 +0200 [thread overview]
Message-ID: <51838255.7040900@metafoo.de> (raw)
In-Reply-To: <1367572164-19523-6-git-send-email-sachin.kamat@linaro.org>
On 05/03/2013 11:09 AM, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Lars-Peter Clausen <lars@metatfoo.de>
Thanks
> ---
> sound/soc/codecs/jz4740.c | 2 --
> sound/soc/jz4740/jz4740-i2s.c | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/sound/soc/codecs/jz4740.c b/sound/soc/codecs/jz4740.c
> index 5f607b3..bcebd1a 100644
> --- a/sound/soc/codecs/jz4740.c
> +++ b/sound/soc/codecs/jz4740.c
> @@ -384,8 +384,6 @@ static int jz4740_codec_remove(struct platform_device *pdev)
> {
> snd_soc_unregister_codec(&pdev->dev);
>
> - platform_set_drvdata(pdev, NULL);
> -
> return 0;
> }
>
> diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740-i2s.c
> index 9a12644..cafc6ed 100644
> --- a/sound/soc/jz4740/jz4740-i2s.c
> +++ b/sound/soc/jz4740/jz4740-i2s.c
> @@ -509,7 +509,6 @@ static int jz4740_i2s_dev_remove(struct platform_device *pdev)
> iounmap(i2s->base);
> release_mem_region(i2s->mem->start, resource_size(i2s->mem));
>
> - platform_set_drvdata(pdev, NULL);
> kfree(i2s);
>
> return 0;
next prev parent reply other threads:[~2013-05-03 9:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 9:09 [PATCH 1/6] ASoC: Samsung: Remove redundant platform_set_drvdata() Sachin Kamat
2013-05-03 9:09 ` [PATCH 2/6] ASoC: omap-mcbsp: " Sachin Kamat
2013-05-03 9:36 ` Mark Brown
2013-05-03 9:09 ` [PATCH 3/6] ASoC: mid-x86: " Sachin Kamat
2013-05-03 9:37 ` Mark Brown
2013-05-03 9:09 ` [PATCH 4/6] ASoC: ep93xx: " Sachin Kamat
2013-05-03 9:38 ` Mark Brown
2013-05-03 9:09 ` [PATCH 5/6] ASoC: 88pm860x: " Sachin Kamat
2013-05-07 1:53 ` Haojian Zhuang
2013-05-03 9:09 ` [PATCH 6/6] ASoC: jz4740: " Sachin Kamat
2013-05-03 9:24 ` Lars-Peter Clausen [this message]
2013-05-03 9:40 ` Mark Brown
2013-05-03 9:34 ` [PATCH 1/6] ASoC: Samsung: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51838255.7040900@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox