Re: [PATCH v3] ASoC: sgtl5000: Fix driver probe after reset

[Lars-Peter Clausen <lars@metafoo.de>]

On 05/09/2013 08:07 PM, Fabio Estevam wrote:
> On Thu, May 9, 2013 at 2:42 PM, Lars-Peter Clausen <lars@metafoo.de> wrote:
> 
>> I don't see how this is different from v2, except that it is now opencoding
>> the register reading and is sharing a driver global variable between
>> multiple instances (which is kind of a no-go).
> 
> Actually I like v2 better, but Mark stated:
> 
> "I'm not sure that removing the defaults is the ideal thing here - it
> means that the driver will be stuck with whatever the last booted OS
> left the device running which may or may not be sane.  Explicitly
> writing in all the values we want seems safer, that way we know how the
> device is configured and there's less potential for odd bugs caused by
> rebooting at the wrong moment."
> 
> So I would appreciate any suggestions.

I think what Mark suggested was to take the register defaults and write them
to the registers in your probe function, so you'll always end up in the same
state.

- Lars