alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mike Looijmans <mike.looijmans@topic.nl>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: "Negative" volume settings in a kcontrol
Date: Fri, 31 May 2013 09:01:22 +0200	[thread overview]
Message-ID: <51A84AC2.5070702@topic.nl> (raw)
In-Reply-To: <20130529194211.GB5180@sirena.org.uk>

On 05/29/2013 09:42 PM, Mark Brown wrote:
> On Tue, May 28, 2013 at 01:46:15PM +0200, Mike Looijmans wrote:
>> On 05/06/2013 03:22 PM, Clemens Ladisch wrote:
>>> Mike Looijmans wrote:
>
> *ALWAYS* CC maintainers on mails and don't drop people from CCs either...

I hereby promise to improve myself in that respect :)

>>> There are some ASoC helper macros that handle signed register fields, such
>>> as SOC_DOUBLE_S8_TLV and SOC_SINGLE_XR_SX.  If those don't do what you want,
>>> you have to write your own.
>
>> SOC_DOUBLE_S8_TLV seems to be a misnamed hardware-specific macro. It
>> provides no way to specify the location of the left/right bits so
>> the macro name is misleading.
>
> That's trivially fixable...

>> SOC_SINGLE_XR_SX is too new for my kernel. And from what I gather, I
>> cannot use it anyway for my purposes. So the solution turns out to
>
> What makes you gather this?

What I actually needed was a SOC_DOUBLE_... thingy. Otherwise, the macro 
was pretty close, but I'm using a 2.6.37 kernel so just backporting the 
snd_soc_*_xr_sx methods would be more work than simply writing new 
info/set/get methods. I also considered the fact that only one driver is 
using the SOC_SINGLE_XR_SX macro a bit of a code smell, so I feared a 
similar experience as with SOC_DOUBLE_S8_TLV which was also introduced 
just for a single driver.


Mike.

  reply	other threads:[~2013-05-31  7:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02 10:55 idea: a reserve alsa plugin David Henningsson
2013-05-02 12:37 ` [pulseaudio-discuss] " Arun Raghavan
2013-05-02 13:23   ` David Henningsson
2013-05-02 14:13   ` "Negative" volume settings in a kcontrol Mike Looijmans
2013-05-06 13:22     ` Clemens Ladisch
2013-05-28 11:46       ` Mike Looijmans
2013-05-29 19:42         ` Mark Brown
2013-05-31  7:01           ` Mike Looijmans [this message]
2013-07-16 13:45             ` Need help diagnosing "hw_ptr skipping" message Mike Looijmans
2013-07-17 14:02               ` Clemens Ladisch
2013-05-02 14:28 ` idea: a reserve alsa plugin Tvrtko Ursulin
2013-05-02 14:37   ` [pulseaudio-discuss] " David Henningsson
2013-05-02 14:50     ` Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A84AC2.5070702@topic.nl \
    --to=mike.looijmans@topic.nl \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).