From: Lars-Peter Clausen <lars@metafoo.de>
To: Rajeev Kumar <rajeev-dlh.kumar@st.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH] ASoC: SPEAr: Add device tree support + SPEAr machine driver
Date: Thu, 20 Jun 2013 14:12:42 +0200 [thread overview]
Message-ID: <51C2F1BA.40903@metafoo.de> (raw)
In-Reply-To: <1371728152-14641-1-git-send-email-rajeev-dlh.kumar@st.com>
On 06/20/2013 01:35 PM, Rajeev Kumar wrote:
> The patch adds device tree support + SPEAr machine driver
>
> Signed-off-by: Rajeev Kumar <rajeev-dlh.kumar@st.com>
> ---
> .../devicetree/bindings/sound/spear-evb.txt | 20 +++
> sound/soc/spear/spear_evb.c | 135 ++++++++++++++++++++
> 2 files changed, 155 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/spear-evb.txt
> create mode 100644 sound/soc/spear/spear_evb.c
>
> diff --git a/Documentation/devicetree/bindings/sound/spear-evb.txt b/Documentation/devicetree/bindings/sound/spear-evb.txt
> new file mode 100644
> index 0000000..cb011b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/spear-evb.txt
> @@ -0,0 +1,20 @@
> +* SPEAr audio sta529 codec
> +
> +Required properties:
> +- compatible: "spear,spear-evb"
> +- audio-controllers: The phandle list of synopsys audio i2s controller
> +- audio-codec: The phandle of the sta529 audio codec
> +- codec_dai_name: DAI name for codec.
> +- stream_name: stream name.
> +
> +Example:
> +
> +sound {
> + compatible = "spear,spear-evb";
> + audio-controllers = <&i2s0 &i2s1>;
> + audio-codecs = <&sta529 &sta529>;
> + codec_dai_name = "sta529-audio", "sta529-audio";
> + stream_name = "i2s-play", "i2s-cap";
> + dai_name = "i2s0-pcm", "i2s1-pcm";
> +};
Kuninori Morimoto was working on generic bindings for the simple-audio
driver a while back. I'm not quite sure what the current status is on this,
but I think it is a better idea to use what he was working on instead of
adding just another set of incompatible platform specific bindings.
See
http://mailman.alsa-project.org/pipermail/alsa-devel/2013-February/059791.html
- Lars
prev parent reply other threads:[~2013-06-20 12:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 11:35 [PATCH] ASoC: SPEAr: Add device tree support + SPEAr machine driver Rajeev Kumar
2013-06-20 12:12 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C2F1BA.40903@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox