From: Lars-Peter Clausen <lars@metafoo.de>
To: Daniel Mack <zonque@gmail.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH 2/3] ASoC: codecs: adau1701: switch to direct regmap API usage
Date: Fri, 21 Jun 2013 09:28:12 +0200 [thread overview]
Message-ID: <51C4008C.20001@metafoo.de> (raw)
In-Reply-To: <1371749397-32238-3-git-send-email-zonque@gmail.com>
On 06/20/2013 07:29 PM, Daniel Mack wrote:
> The hardware I/O has to be open-coded due to registers of unequal sizes.
> Other than that, the transition is straight forward.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks. One minor nitpick though.
> ---
[...]
> + msgs[0].addr = client->addr;
> + msgs[0].len = sizeof(send_buf);
> + msgs[0].buf = send_buf;
> + msgs[0].flags = 0;
> +
> + msgs[1].addr = client->addr;
> + msgs[1].len = size;
> + msgs[1].buf = recv_buf;
> + msgs[1].flags = I2C_M_RD | I2C_M_STOP;
We don't need to set a explicit stop flag for the last message in the transfer.
next prev parent reply other threads:[~2013-06-21 7:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-20 17:29 [PATCH v2 0/3] ASoC: codecs: some more improvements for adau1701 Daniel Mack
2013-06-20 17:29 ` [PATCH 1/3] ASoC: codecs: adau1701: allow configuration of PLL mode pins Daniel Mack
2013-06-21 4:46 ` Rajeev kumar
2013-06-21 6:06 ` Daniel Mack
2013-06-21 8:14 ` Rajeev kumar
2013-06-21 8:17 ` Daniel Mack
2013-06-21 8:18 ` Lars-Peter Clausen
2013-06-21 7:23 ` Lars-Peter Clausen
2013-06-21 7:31 ` Daniel Mack
2013-06-21 7:39 ` Lars-Peter Clausen
2013-06-20 17:29 ` [PATCH 2/3] ASoC: codecs: adau1701: switch to direct regmap API usage Daniel Mack
2013-06-21 7:28 ` Lars-Peter Clausen [this message]
2013-06-21 7:31 ` Daniel Mack
2013-06-20 17:29 ` [PATCH 3/3] ASoC: codecs: adau1701: add support for pin muxing Daniel Mack
2013-06-21 7:24 ` Lars-Peter Clausen
2013-06-21 7:28 ` Daniel Mack
2013-06-21 7:35 ` Lars-Peter Clausen
2013-06-21 7:38 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C4008C.20001@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox