From: Bo Shen <voice.shen@atmel.com>
To: Mark Brown <broonie@kernel.org>
Cc: plagnioj@jcrosoft.com, alsa-devel@alsa-project.org,
nicolas.ferre@atmel.com, linux-arm-kernel@lists.infradead.org,
linux-sound@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: atmel: add wm8904 based audio machine driver
Date: Fri, 19 Jul 2013 14:06:20 +0800 [thread overview]
Message-ID: <51E8D75C.7030707@atmel.com> (raw)
In-Reply-To: <51E8A6EF.4040608@atmel.com>
Hi Mark,
On 07/19/2013 10:39 AM, Bo Shen wrote:
>
>>> +#define MCLK_RATE 32768
>>> +
>>> +static struct clk *mclk;
>>
>> This should be in driver data for the board. Shouldn't the clock be
>> referenced using the clock bindings?
>
> I will try to implement this in next version.
After check the clock implementation, we are on the way to common clock
framework, so will do this after we fully transfer to common clock.
Best Regards,
Bo Shen
next prev parent reply other threads:[~2013-07-19 6:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 7:28 [PATCH] ASoC: atmel: add wm8904 based audio machine driver Bo Shen
2013-07-18 11:17 ` Mark Brown
2013-07-19 2:39 ` Bo Shen
2013-07-19 6:06 ` Bo Shen [this message]
2013-07-19 10:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E8D75C.7030707@atmel.com \
--to=voice.shen@atmel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).