From: Lars-Peter Clausen <lars@metafoo.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Jean-Francois Moine <moinejf@free.fr>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <rob.herring@calxeda.com>,
devicetree-discuss@vger.kernel.org,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage
Date: Tue, 23 Jul 2013 11:03:38 +0200 [thread overview]
Message-ID: <51EE46EA.1020809@metafoo.de> (raw)
In-Reply-To: <20130723085346.GQ24642@n2100.arm.linux.org.uk>
On 07/23/2013 10:53 AM, Russell King - ARM Linux wrote:
> On Tue, Jul 23, 2013 at 10:46:15AM +0200, Jean-Francois Moine wrote:
>> The kirkwood i2s driver is used without DT in the Kirkwood machine.
>> This patch adds a DT compatible definition for use in other Marvell
>> machines as the Armada 88AP510 (Dove).
>
> Yet again, this illustrates why converting to DT causes backwards
> steps in drivers: the conversion of devm_clk_get() to of_clk_get()
> necessitates a clk_put().
That's just a very poor usage of the API in this patch. devm_clk_get() works
fine on DT and non-DT platforms. The driver shouldn't need any changes in
that regard.
- Lars
next prev parent reply other threads:[~2013-07-23 9:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 8:46 [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage Jean-Francois Moine
2013-07-23 8:53 ` Russell King - ARM Linux
2013-07-23 9:03 ` Lars-Peter Clausen [this message]
2013-07-23 9:08 ` Sascha Hauer
2013-07-23 9:39 ` Russell King - ARM Linux
2013-07-23 9:48 ` [alsa-devel] " Sascha Hauer
2013-07-23 12:34 ` Mark Brown
2013-07-23 12:59 ` [alsa-devel] " Sebastian Hesselbarth
2013-07-23 13:20 ` Mark Brown
2013-07-23 13:30 ` Sebastian Hesselbarth
2013-07-23 13:50 ` Russell King - ARM Linux
2013-07-23 17:04 ` Mark Brown
2013-07-23 15:01 ` [alsa-devel] " Mark Brown
2013-07-23 15:19 ` Russell King - ARM Linux
2013-07-23 17:16 ` Mark Brown
2013-07-23 15:34 ` [alsa-devel] " Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EE46EA.1020809@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree-discuss@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=moinejf@free.fr \
--cc=rob.herring@calxeda.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).