From: Daniel Mack <zonque@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: ALSA development <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: Ambiguous DAPM widget names and DPCM
Date: Thu, 25 Jul 2013 14:24:54 +0200 [thread overview]
Message-ID: <51F11916.1080002@gmail.com> (raw)
In-Reply-To: <20130723183038.GO9858@sirena.org.uk>
On 23.07.2013 20:30, Mark Brown wrote:
> On Tue, Jul 23, 2013 at 05:34:59PM +0200, Daniel Mack wrote:
>> With printk() in snd_soc_dapm_new_control(), I see the following widgets
>> being created during boot (one pair for each Codec, and two pairs for
>> the platform dai):
>
> OK, so the issue here is probably that you're overloading the single
> McASP object rather than anything else
Hmm, I'm not following. Isn't that the way things are supposed to work
with DPCM?
> Lookups are done first in the local DAPM context so so long as the thing
> that's setting up the links is doing so in the same context everything
> should be OK. This is needed so you can have two of the same device in
> a system.
Hmm, but DPCM does not have such a local context, and just tries to look
up the widgets by name globally.
> The prefix mechanism is intended to address this; however it's only
> currently supported for CODECs. If we move the prefixes to components
> then they should be usable for CPU DAIs.
But that's a static string as well. How can we distiguish between two
Codecs of the same type, or two McASP instances?
All of that might not have been a big issue so far maybe, but with DPMC,
we need to make the names unique, and add a way to uniquely identify
each widget along with its device identifier.
Liam, could you explain what you think makes sense here?
Thanks,
Daniel
next prev parent reply other threads:[~2013-07-25 12:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 8:30 Ambiguous DAPM widget names and DPCM Daniel Mack
2013-07-23 12:30 ` Mark Brown
2013-07-23 15:34 ` Daniel Mack
2013-07-23 18:30 ` Mark Brown
2013-07-25 12:24 ` Daniel Mack [this message]
2013-07-25 12:48 ` Mark Brown
2013-07-25 19:53 ` Liam Girdwood
2013-07-26 9:13 ` Peter Ujfalusi
2013-07-23 12:48 ` Liam Girdwood
2014-03-21 16:50 ` Patrick Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F11916.1080002@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).