From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
swarren@nvidia.com, swarren@wwwdotorg.org, lgirdwood@gmail.com,
bardliao@realtek.com, flove@realtek.com
Subject: Re: [PATCH] ASoC: rt5640: change widget sequence for depop
Date: Mon, 05 Aug 2013 19:21:21 +0200 [thread overview]
Message-ID: <51FFDF11.5020106@metafoo.de> (raw)
In-Reply-To: <20130805144808.GG9858@sirena.org.uk>
On 08/05/2013 04:48 PM, Mark Brown wrote:
> On Mon, Aug 05, 2013 at 12:19:03PM +0800, bardliao@realtek.com wrote:
>> From: Bard Liao <bardliao@realtek.com>
>>
>> Add mute/unmute control in widget event and modify the power on/off sequence to avoid pop noise.
>
> This looks like you should be using Lars-Peter's patch for controls that
> are disabled while a widget isn't powered - as far as I can tell from a
> quick read through all this does is keep the speaker/headphone muted
> while the outputs are powered down.
The driver is using stereo controls though. So either support for stereo
controls needs to be added to DAPM (which shouldn't be too hard) or the
control needs to be split into two mono controls.
- Lars
next prev parent reply other threads:[~2013-08-05 17:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 4:19 [PATCH] ASoC: rt5640: change widget sequence for depop bardliao
2013-08-05 14:48 ` Mark Brown
2013-08-05 17:21 ` Lars-Peter Clausen [this message]
2013-08-05 17:58 ` Mark Brown
2013-08-06 8:07 ` [PATCH] ASoC: rt5640: change widget sequencefordepop Bard Liao
2013-08-06 8:45 ` Lars-Peter Clausen
2013-08-06 9:13 ` [PATCH] ASoC: rt5640: change widgetsequencefordepop Bard Liao
2013-08-06 9:35 ` Lars-Peter Clausen
2013-08-06 10:07 ` Bard Liao
2013-08-06 10:16 ` Lars-Peter Clausen
2013-08-06 11:04 ` Bard Liao
2013-08-06 11:31 ` Lars-Peter Clausen
2013-08-07 1:32 ` Bard Liao
2013-08-07 5:40 ` Bard Liao
2013-08-07 7:45 ` Lars-Peter Clausen
2013-08-07 8:03 ` Bard Liao
2013-08-07 8:26 ` Lars-Peter Clausen
2013-08-07 8:31 ` Bard Liao
2013-08-07 9:36 ` Mark Brown
2013-08-07 10:47 ` Lars-Peter Clausen
2013-08-07 13:05 ` Mark Brown
2013-08-09 9:05 ` Bard Liao
2013-08-09 13:37 ` Lars-Peter Clausen
2013-08-09 14:58 ` Mark Brown
2013-08-12 7:27 ` Bard Liao
2013-08-05 17:17 ` [PATCH] ASoC: rt5640: change widget sequence for depop Stephen Warren
2013-08-05 17:19 ` Lars-Peter Clausen
-- strict thread matches above, loose matches on Subject: below --
2013-08-19 12:18 bardliao
2013-08-19 17:29 ` Stephen Warren
2013-08-20 2:36 ` Bard Liao
2013-08-20 16:15 ` Stephen Warren
2013-08-21 19:56 ` Lars-Peter Clausen
2013-08-02 2:38 bardliao
2013-08-02 15:53 ` Stephen Warren
2013-08-05 3:34 ` Bard Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FFDF11.5020106@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).