From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: "Бойко Максим" <maksboyko-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org>
Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Fix invalid volume resolution for Logitech HD Webcam C525
Date: Wed, 07 Aug 2013 23:40:31 +0400 [thread overview]
Message-ID: <5202A2AF.60900@cogentembedded.com> (raw)
In-Reply-To: <80181375903486-HW/GO1vs6rtxpj1cXAZ9Bg@public.gmane.org>
Hello.
On 08/07/2013 11:24 PM, Бойко Максим wrote:
> From: Maksim Boyko <maksim.a.boyko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Add the volume control quirk for avoiding the kernel warning for Logitech HD Webcam C525.
> The similar patch was previously reported for Logitech HD Webcam C310 (see 36691e1be6ec551eef4a5225f126a281f8c051c2).
Please also specif that commit's summary line in parens.
And wrap your changelog lines at 80 columns at least.
> --- linux-3.10.5-orig/sound/usb/mixer.c 2013-08-04 12:51:49.000000000 +0400
> +++ linux-3.10.5/sound/usb/mixer.c 2013-08-06 21:12:42.274197287 +0400
> @@ -888,6 +888,7 @@
> case USB_ID(0x046d, 0x081b): /* HD Webcam c310 */
> case USB_ID(0x046d, 0x081d): /* HD Webcam c510 */
> case USB_ID(0x046d, 0x0825): /* HD Webcam c270 */
> + case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
> case USB_ID(0x046d, 0x0991):
> /* Most audio usb devices lie about volume resolution.
> * Most Logitech webcams have res = 384.
Hm, the file has bad indentation (your added line is fine unless it's out
of sync with the surrounding ones).
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-08-07 19:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 19:24 [PATCH] Fix invalid volume resolution for Logitech HD Webcam C525 Бойко Максим
2013-08-07 19:34 ` Greg KH
[not found] ` <80181375903486-HW/GO1vs6rtxpj1cXAZ9Bg@public.gmane.org>
2013-08-07 19:40 ` Sergei Shtylyov [this message]
2013-08-08 8:42 ` [alsa-devel] " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5202A2AF.60900@cogentembedded.com \
--to=sergei.shtylyov-m4dtvfq/zs1mrggop+s0pdbpr1lh4cv8@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maksboyko-o+MxOtu4lMCHXe+LvDLADg@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).