[PATCH] Fix invalid volume resolution for Logitech HD Webcam C525

[PATCH] Fix invalid volume resolution for Logitech HD Webcam C525

[Бойко Максим]

From: Maksim Boyko <maksim.a.boyko@gmail.com>

Add the volume control quirk for avoiding the kernel warning for Logitech HD Webcam C525.
The similar patch was previously reported for Logitech HD Webcam C310 (see 36691e1be6ec551eef4a5225f126a281f8c051c2).

--- linux-3.10.5-orig/sound/usb/mixer.c	2013-08-04 12:51:49.000000000 +0400
+++ linux-3.10.5/sound/usb/mixer.c	2013-08-06 21:12:42.274197287 +0400
@@ -888,6 +888,7 @@
         case USB_ID(0x046d, 0x081b): /* HD Webcam c310 */
         case USB_ID(0x046d, 0x081d): /* HD Webcam c510 */
         case USB_ID(0x046d, 0x0825): /* HD Webcam c270 */
+	case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
         case USB_ID(0x046d, 0x0991):
         /* Most audio usb devices lie about volume resolution.
          * Most Logitech webcams have res = 384.

Re: [PATCH] Fix invalid volume resolution for Logitech HD Webcam C525

[Greg KH]

On Wed, Aug 07, 2013 at 11:24:46PM +0400, Бойко Максим wrote:
> From: Maksim Boyko <maksim.a.boyko@gmail.com>
> 
> Add the volume control quirk for avoiding the kernel warning for Logitech HD Webcam C525.
> The similar patch was previously reported for Logitech HD Webcam C310 (see 36691e1be6ec551eef4a5225f126a281f8c051c2).
> 
> --- linux-3.10.5-orig/sound/usb/mixer.c	2013-08-04 12:51:49.000000000 +0400
> +++ linux-3.10.5/sound/usb/mixer.c	2013-08-06 21:12:42.274197287 +0400
> @@ -888,6 +888,7 @@
>          case USB_ID(0x046d, 0x081b): /* HD Webcam c310 */
>          case USB_ID(0x046d, 0x081d): /* HD Webcam c510 */
>          case USB_ID(0x046d, 0x0825): /* HD Webcam c270 */
> +	case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
>          case USB_ID(0x046d, 0x0991):
>          /* Most audio usb devices lie about volume resolution.
>           * Most Logitech webcams have res = 384.


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

Re: [PATCH] Fix invalid volume resolution for Logitech HD Webcam C525

[Sergei Shtylyov]

Hello.

On 08/07/2013 11:24 PM, Бойко Максим wrote:

> From: Maksim Boyko <maksim.a.boyko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

> Add the volume control quirk for avoiding the kernel warning for Logitech HD Webcam C525.
> The similar patch was previously reported for Logitech HD Webcam C310 (see 36691e1be6ec551eef4a5225f126a281f8c051c2).

    Please also specif that commit's summary line in parens.
And wrap your changelog lines at 80 columns at least.

> --- linux-3.10.5-orig/sound/usb/mixer.c	2013-08-04 12:51:49.000000000 +0400
> +++ linux-3.10.5/sound/usb/mixer.c	2013-08-06 21:12:42.274197287 +0400
> @@ -888,6 +888,7 @@
>           case USB_ID(0x046d, 0x081b): /* HD Webcam c310 */
>           case USB_ID(0x046d, 0x081d): /* HD Webcam c510 */
>           case USB_ID(0x046d, 0x0825): /* HD Webcam c270 */
> +	case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
>           case USB_ID(0x046d, 0x0991):
>           /* Most audio usb devices lie about volume resolution.
>            * Most Logitech webcams have res = 384.

    Hm, the file has bad indentation (your added line is fine unless it's out 
of sync with the surrounding ones).

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [alsa-devel] [PATCH] Fix invalid volume resolution for Logitech HD Webcam C525

[Takashi Iwai]

At Wed, 07 Aug 2013 23:24:46 +0400,
Бойко Максим wrote:
> 
> From: Maksim Boyko <maksim.a.boyko@gmail.com>
> 
> Add the volume control quirk for avoiding the kernel warning for Logitech HD Webcam C525.
> The similar patch was previously reported for Logitech HD Webcam C310 (see 36691e1be6ec551eef4a5225f126a281f8c051c2).

Your sign-off is missing.  And the patch can't be applied cleanly as
is, likely because your MUA broke the spaces/tabs.

Could you resubmit with the fixes?


thanks,

Takashi


> 
> --- linux-3.10.5-orig/sound/usb/mixer.c	2013-08-04 12:51:49.000000000 +0400
> +++ linux-3.10.5/sound/usb/mixer.c	2013-08-06 21:12:42.274197287 +0400
> @@ -888,6 +888,7 @@
>          case USB_ID(0x046d, 0x081b): /* HD Webcam c310 */
>          case USB_ID(0x046d, 0x081d): /* HD Webcam c510 */
>          case USB_ID(0x046d, 0x0825): /* HD Webcam c270 */
> +	case USB_ID(0x046d, 0x0826): /* HD Webcam c525 */
>          case USB_ID(0x046d, 0x0991):
>          /* Most audio usb devices lie about volume resolution.
>           * Most Logitech webcams have res = 384.
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>