From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Michael Trimarchi <michael@amarulasolutions.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: [RFC PATCH] ASoC: omap-mcbsp: Add support for highter rate up to 384000
Date: Thu, 8 Aug 2013 13:51:25 +0300 [thread overview]
Message-ID: <5203782D.1080008@ti.com> (raw)
In-Reply-To: <20130807182841.GA7823@panicking>
On 08/07/2013 09:28 PM, Michael Trimarchi wrote:
> Add support for highter rate up to 384000Khz. There are codecs in the
> market that can play up to this frequency.
> Test was done just with:
>
> #define OMAP_MCBSP_RATES (SNDRV_PCM_RATE_8000_192000)
>
> playing wav file 32bit/192000Khz stereo. Some glitch has observed
> but this should depend on the selected min buffer bytes that was
> left untouched in aplay and in the omap-pcm driver.
>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
> sound/soc/omap/omap-mcbsp.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
> index 7483efb..1e95f6a 100644
> --- a/sound/soc/omap/omap-mcbsp.c
> +++ b/sound/soc/omap/omap-mcbsp.c
> @@ -39,7 +39,9 @@
> #include "mcbsp.h"
> #include "omap-mcbsp.h"
>
> -#define OMAP_MCBSP_RATES (SNDRV_PCM_RATE_8000_96000)
> +#define OMAP_MCBSP_RATES (SNDRV_PCM_RATE_8000_192000 | \
I think only this change is enough for what you want to achieve.
> + SNDRV_PCM_RATE_CONTINUOUS | \
> + SNDRV_PCM_RATE_KNOT)
The _KNOT is for sure not needed and I would not set the CONTINUOUS either.
>
> #define OMAP_MCBSP_SOC_SINGLE_S16_EXT(xname, xmin, xmax, \
> xhandler_get, xhandler_put) \
> @@ -574,11 +576,15 @@ static struct snd_soc_dai_driver omap_mcbsp_dai = {
> .channels_max = 16,
> .rates = OMAP_MCBSP_RATES,
> .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S32_LE,
> + .rate_min = 8000,
> + .rate_max = 384000,
Why you want to limit the rates here?
> },
> .capture = {
> .channels_min = 1,
> .channels_max = 16,
> .rates = OMAP_MCBSP_RATES,
> + .rate_min = 8000,
> + .rate_max = 384000,
Same here, do not set these.
> .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S32_LE,
> },
> .ops = &mcbsp_dai_ops,
>
--
Péter
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2013-08-08 10:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 18:28 [RFC PATCH] ASoC: omap-mcbsp: Add support for highter rate up to 384000 Michael Trimarchi
2013-08-08 10:51 ` Peter Ujfalusi [this message]
2013-08-08 11:04 ` Michael Trimarchi
2013-08-09 5:18 ` Peter Ujfalusi
2013-08-09 7:43 ` Michael Trimarchi
2013-08-10 7:53 ` Michael Trimarchi
2013-08-12 15:36 ` Peter Ujfalusi
2013-08-12 15:57 ` Michael Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5203782D.1080008@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=lgirdwood@gmail.com \
--cc=michael@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox