From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH] ASoC: rt5640: change widgetsequencefordepop Date: Fri, 09 Aug 2013 15:37:46 +0200 Message-ID: <5204F0AA.1070209@metafoo.de> References: <1121E117AD4ECE49880A389A396215BB935C692E40@rtitmbs7.realtek.com.tw> <5200C369.6050607@metafoo.de> <1121E117AD4ECE49880A389A396215BB935C692E62@rtitmbs7.realtek.com.tw> <5200CD0D.7030007@metafoo.de> <1121E117AD4ECE49880A389A396215BB935C692E81@rtitmbs7.realtek.com.tw> <5200DE78.5060409@metafoo.de> <1121E117AD4ECE49880A389A396215BB935C692F72@rtitmbs7.realtek.com.tw> <5201FB09.1080105@metafoo.de> <1121E117AD4ECE49880A389A396215BB935C692FD9@rtitmbs7.realtek.com.tw> <520204BB.9080603@metafoo.de> <20130807093629.GU6427@sirena.org.uk> <520225B4.5050208@metafoo.de> <1121E117AD4ECE49880A389A396215BB935C6932CF@rtitmbs7.realtek.com.tw> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-out-015.synserver.de (smtp-out-016.synserver.de [212.40.185.16]) by alsa0.perex.cz (Postfix) with ESMTP id C596B26579B for ; Fri, 9 Aug 2013 15:36:40 +0200 (CEST) In-Reply-To: <1121E117AD4ECE49880A389A396215BB935C6932CF@rtitmbs7.realtek.com.tw> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Bard Liao Cc: Oder Chiou , "alsa-devel@alsa-project.org" , "swarren@nvidia.com" , "swarren@wwwdotorg.org" , "lgirdwood@gmail.com" , Mark Brown , Flove List-Id: alsa-devel@alsa-project.org On 08/09/2013 11:05 AM, Bard Liao wrote: >> One thing that could work is to setup SND_SOC_DAPM_{PRE,POST}_REG >> events for the SWITCH widget. This callback gets called whenever user >> changes the control (and it is not disabled by DAPM). The next step then would >> be to set up an internal event callback for kcontrol widgets which then again >> calls the event callbacks for the kcontrol's widgets like we do in >> dapm_widget_update(). But I'm not convinced that this is the best way to solve >> this. I think it makes things more complicated than they need to be. I think >> having a OUTDRV widget along the path that runs the mute and unmute >> sequence might be a better option. >> And then have virtual switch control to let userspace disconnect the path, so >> that it is still possbile to manually mute it. > > Does "virtual switch control" mean a switch control which will not touch the codec's register actually? Yes. But Mark seems to prefer the solution using {PRE,POST}_REG events. - Lars