alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: "Nathanael D. Noblet" <nathanael@gnat.ca>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>,
	David Henningsson <david.henningsson@canonical.com>,
	Kailang Yang <kailang@realtek.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: RealTek Inverted Mic Patch
Date: Fri, 16 Aug 2013 09:28:40 -0600	[thread overview]
Message-ID: <520E4528.7020002@gnat.ca> (raw)
In-Reply-To: <s5hvc36ma1m.wl%tiwai@suse.de>

[-- Attachment #1: Type: text/plain, Size: 1880 bytes --]

Hello,

   Thanks for applying it - there is one more piece of hardware that 
needs the same type of fix. Here's an updated patch...
just the addition of

SND_PCI_QUIRK(0x1025, 0x022f, "Acer Aspire One", ALC662_FIXUP_INV_DMIC),

over and above what was already in the last patch..

On 08/16/2013 12:20 AM, Takashi Iwai wrote:
> At Thu, 15 Aug 2013 14:27:07 -0600,
> Nathanael D. Noblet wrote:
>>
>> Hello,
>>
>>     I have hardware that suffers from an internal phase inverted mic that
>> isn't properly detected. Below is a patch that fixes the issue for my
>> particular hardware.
>>
>> Pre patch alsa-info:
>>
>> http://www.alsa-project.org/db/?f=a922c77ddf473a8f478ec334fa9dca684f213b59
>>
>> Post patch alsa-info:
>> http://www.alsa-project.org/db/?f=14cd25b323d3bbb02fabbac78e62851569893c3f
>>
>> Incase you care. The patch is small. I don't know if you need any kind
>> of signed off/written by etc for something so small. In any case there
>> is no intellectual property in this at all. Feel free to do as you wish
>> with it. However including it in the kernel would make my life easier.
>
> Thanks, I fixed it in sound git tree now.
>
>
> Takashi
>
>>
>> Thanks,
>> --
>> Nathanael d. Noblet
>> t 403.875.4613
>> [2 alsa-realtek-inverted-mic.patch <text/x-patch (7bit)>]
>> --- a/sound/pci/hda/patch_realtek.c.org	2013-08-15 13:17:49.804492932 -0600
>> +++ b/sound/pci/hda/patch_realtek.c	2013-08-15 13:18:40.582364931 -0600
>> @@ -4208,6 +4208,7 @@
>>   	SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo Ideapad Y550", ALC662_FIXUP_IDEAPAD),
>>   	SND_PCI_QUIRK(0x19da, 0xa130, "Zotac Z68", ALC662_FIXUP_ZOTAC_Z68),
>>   	SND_PCI_QUIRK(0x1b35, 0x2206, "CZC P10T", ALC662_FIXUP_CZC_P10T),
>> +    SND_PCI_QUIRK(0x1025, 0x034a, "Gateway LT27", ALC662_FIXUP_INV_DMIC),
>>
>>   #if 0
>>   	/* Below is a quirk table taken from the old code.
>


-- 
Nathanael d. Noblet
t 403.875.4613

[-- Attachment #2: alsa-realtek-inverted-mic.patch --]
[-- Type: text/x-patch, Size: 591 bytes --]

--- a/sound/pci/hda/patch_realtek.c	2013-08-15 13:17:49.804492932 -0600
+++ b/sound/pci/hda/patch_realtek.c	2013-08-15 15:17:46.390273328 -0600
@@ -4208,6 +4208,8 @@
 	SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo Ideapad Y550", ALC662_FIXUP_IDEAPAD),
 	SND_PCI_QUIRK(0x19da, 0xa130, "Zotac Z68", ALC662_FIXUP_ZOTAC_Z68),
 	SND_PCI_QUIRK(0x1b35, 0x2206, "CZC P10T", ALC662_FIXUP_CZC_P10T),
+	SND_PCI_QUIRK(0x1025, 0x034a, "Gateway LT27", ALC662_FIXUP_INV_DMIC),
+	SND_PCI_QUIRK(0x1025, 0x022f, "Acer Aspire One", ALC662_FIXUP_INV_DMIC),
 
 #if 0
 	/* Below is a quirk table taken from the old code.

      reply	other threads:[~2013-08-16 15:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-15 20:27 RealTek Inverted Mic Patch Nathanael D. Noblet
2013-08-16  6:20 ` Takashi Iwai
2013-08-16 15:28   ` Nathanael D. Noblet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520E4528.7020002@gnat.ca \
    --to=nathanael@gnat.ca \
    --cc=alsa-devel@alsa-project.org \
    --cc=david.henningsson@canonical.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).