From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Kacur Subject: Re: WARNING: at sound/core/sound_oss.c:96 snd_oss_kernel_minor+0xdf/0x120 [snd]() Date: Mon, 18 Jan 2010 09:15:23 +0100 Message-ID: <520f0cf11001180015ub28da4fp4c8c38d3c02c78d5@mail.gmail.com> References: <520f0cf11001060853i5c296744rf94c947cb7798774@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Takashi Iwai Cc: LKML , Jaroslav Kysela , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Tue, Jan 12, 2010 at 9:57 AM, Takashi Iwai wrote: > At Wed, 6 Jan 2010 17:53:24 +0100, > John Kacur wrote: >> >> The following was in my 2.6.33-rc3 dmesg (of course that doesn't mea= n >> that the problem didn't exist earlier too) >> >> WARNING: at /home/jkacur/rt.linux.git/sound/core/sound_oss.c:96 >> snd_oss_kernel_minor+0xdf/0x120 [snd]() >> Hardware name: 2241B48 >> BUG? (minor < 0 || minor >=3D 128) >> Modules linked in: snd_mixer_oss thinkpad_acpi(+) sdhci hwmon i2c_i8= 01 >> firewire_ohci snd_pcm mmc_core snd_timer cfg80211 firewire_core btus= b >> joydev iTCO_wdt bluetooth ata_generic e1000e i2c_core ppdev snd >> battery ac iTCO_vendor_support parport_pc ricoh_mmc intel_agp >> pata_acpi pcspkr parport tpm_tis video wmi output soundcore button t= pm >> rfkill sr_mod tpm_bios snd_page_alloc crc_itu_t cdrom sg ahci libata >> sd_mod scsi_mod crc_t10dif xfs exportfs uhci_hcd ohci_hcd ehci_hcd >> [last unloaded: scsi_wait_scan] >> Pid: 1317, comm: modprobe Not tainted 2.6.33-rc3 #1 >> Call Trace: >> =A0[] ? snd_oss_kernel_minor+0xdf/0x120 [snd] >> =A0[] warn_slowpath_common+0x7c/0xa9 >> =A0[] warn_slowpath_fmt+0x41/0x43 >> =A0[] snd_oss_kernel_minor+0xdf/0x120 [snd] >> =A0[] snd_register_oss_device+0x2c/0x21a [snd] >> =A0[] snd_mixer_oss_notify_handler+0xa5/0x2e5 [snd= _mixer_oss] >> =A0[] ? __mutex_unlock_slowpath+0x5c/0x141 >> =A0[] ? trace_hardirqs_on_caller+0x11f/0x14a >> =A0[] ? trace_hardirqs_on+0xd/0xf >> sdhci-pci 0000:15:00.2: SDHCI controller found [1180:0822] (rev 21) >> sdhci-pci 0000:15:00.2: PCI INT C -> GSI 18 (level, low) -> IRQ 18 >> =A0[] ? __mutex_unlock_slowpath+0x12f/0x141 >> sdhci-pci 0000:15:00.2: Will use DMA mode even though HW doesn't ful= ly >> claim to support it. >> Registered led device: mmc0:: >> mmc0: SDHCI controller on PCI [0000:15:00.2] using DMA >> =A0[] snd_card_register+0x135/0x14b [snd] >> =A0[] volume_init+0x335/0x3d2 [thinkpad_acpi] >> =A0[] thinkpad_acpi_module_init+0x61f/0xa4f [think= pad_acpi] >> =A0[] ? thinkpad_acpi_module_init+0x0/0xa4f [think= pad_acpi] >> =A0[] do_one_initcall+0x5f/0x154 >> =A0[] sys_init_module+0xd7/0x234 >> =A0[] system_call_fastpath+0x16/0x1b >> ---[ end trace a6d53dc318f09cb5 ]--- > > Looks like the code path from thinkpad-acpi... > > Could you add some printk's in sound/core/sound_oss.c:snd_oss_kernel_= minor() > to inspect which values are taken and calculated? > I'm getting a card->number equal to 29, and a dev equal to 0. The case is SNDRV_OSS_DEVICE_TYPE_MIXER: So that does minor =3D SNDRV_MINOR_OSS(card->number, (dev ? SNDRV_MINOR_OSS_MIXER1 : SNDRV_MINOR_OSS_MIXER)); and according to the formula #define SNDRV_MINOR_OSS(card, dev) (((card) << 4) | (dev)) That works out to 464 which of course is not in the acceptable range between 0 and 128. John